system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-10-15 12:54:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

ffs: softdep_disk_write_complete: Quiesce spurious Coverity warning

Browse source 
Coverity cannot determine that handle_written_indirdep() does not access
uninitialized 'sbp' when flags argument is zero.

So, simply move the initialization slightly sooner to silence the warning.

No functional change.

Reported by:	Coverity
Sponsored by:	Dell EMC Isilon
This commit is contained in:
Conrad Meyer 2018-03-01 00:29:52 +00:00
parent 7feea4075b
commit d4e6557bae
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=330135
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
sys/ufs/ffs/ffs_softdep.c
View file

@ -10984,6 +10984,8 @@ softdep_disk_write_complete(bp)
if (ump == NULL)
return;
sbp = NULL;
/*
* If an error occurred while doing the write, then the data
* has not hit the disk and the dependencies cannot be processed.
@ -11026,7 +11028,6 @@ softdep_disk_write_complete(bp)
/*
* Ump SU lock must not be released anywhere in this code segment.
*/
sbp = NULL;
owk = NULL;
while ((wk = LIST_FIRST(&bp->b_dep)) != NULL) {
WORKLIST_REMOVE(wk);