system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-09-22 09:43:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

brelse() was improperly clearing B_DELWRI in the B_DELWRI|B_INVAL case

Browse source 
without removing the buffer from the vnode's dirty buffer list, which
can result in a panic in NFS.  Replaced the code with a call to bundirty()
which deals with it properly.

PR:		kern/36108, kern/36174
Submitted by:	various people
Special mention: to Danny Schales <dan@coes.LaTech.edu> for providing a core dump that helped me track this down.
MFC after:	1 day
This commit is contained in:
Matthew Dillon 2002-04-03 00:17:36 +00:00
parent 1923f73990
commit d1b534dfc6
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=93707
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
sys/kern/vfs_bio.c
View file

@ -1338,11 +1338,8 @@ brelse(struct buf * bp)
* If B_INVAL, clear B_DELWRI. We've already placed the buffer * If B_INVAL, clear B_DELWRI. We've already placed the buffer
* on the correct queue. * on the correct queue.
*/ */
if ((bp->b_flags & (B_INVAL|B_DELWRI)) == (B_INVAL|B_DELWRI)) { if ((bp->b_flags & (B_INVAL|B_DELWRI)) == (B_INVAL|B_DELWRI))
bp->b_flags &= ~B_DELWRI; bundirty(bp);
--numdirtybuffers;
numdirtywakeup(lodirtybuffers);
}
/* /*
* Fixup numfreebuffers count. The bp is on an appropriate queue * Fixup numfreebuffers count. The bp is on an appropriate queue