system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-22 02:37:15 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

ddb: Don't flag breakpoint/watchpoint commands as MEMSAFE

Browse source 
They could potentially be abused to overwrite kernel memory, so
shouldn't be accessible when mac_ddb is loaded.

Reviewed by:	mhorne
Fixes:	bc4ea61d55cb ("ddb: tag core commands with DB_CMD_MEMSAFE")
Sponsored by:	Juniper Networks, Inc.
Sponsored by:	Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D37105
This commit is contained in:
Mark Johnston 2022-11-02 13:20:11 -04:00
parent d93ec8cb13
commit c036339ddf
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
sys/ddb/db_command.c
View file

@ -126,15 +126,15 @@ static struct db_command db_cmds[] = {
DB_CMD("set", db_set_cmd, CS_OWN|DB_CMD_MEMSAFE),
DB_CMD("write", db_write_cmd, CS_MORE|CS_SET_DOT),
DB_CMD("w", db_write_cmd, CS_MORE|CS_SET_DOT),
DB_CMD("delete", db_delete_cmd, DB_CMD_MEMSAFE),
DB_CMD("d", db_delete_cmd, DB_CMD_MEMSAFE),
DB_CMD("delete", db_delete_cmd, 0),
DB_CMD("d", db_delete_cmd, 0),
DB_CMD("dump", db_dump, DB_CMD_MEMSAFE),
DB_CMD("break", db_breakpoint_cmd, DB_CMD_MEMSAFE),
DB_CMD("b", db_breakpoint_cmd, DB_CMD_MEMSAFE),
DB_CMD("dwatch", db_deletewatch_cmd, DB_CMD_MEMSAFE),
DB_CMD("watch", db_watchpoint_cmd, CS_MORE|DB_CMD_MEMSAFE),
DB_CMD("dhwatch", db_deletehwatch_cmd, DB_CMD_MEMSAFE),
DB_CMD("hwatch", db_hwatchpoint_cmd, DB_CMD_MEMSAFE),
DB_CMD("break", db_breakpoint_cmd, 0),
DB_CMD("b", db_breakpoint_cmd, 0),
DB_CMD("dwatch", db_deletewatch_cmd, 0),
DB_CMD("watch", db_watchpoint_cmd, CS_MORE),
DB_CMD("dhwatch", db_deletehwatch_cmd, 0),
DB_CMD("hwatch", db_hwatchpoint_cmd, 0),
DB_CMD("step", db_single_step_cmd, DB_CMD_MEMSAFE),
DB_CMD("s", db_single_step_cmd, DB_CMD_MEMSAFE),
DB_CMD("continue", db_continue_cmd, DB_CMD_MEMSAFE),