system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-10-17 13:53:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

To avoid LOR, always drop the filedesc lock before exporting fd to sbuf.

Browse source 
Reviewed by:	kib
MFC after:	3 days
This commit is contained in:
Mikolaj Golub 2013-06-27 19:14:03 +00:00
parent 9942898697
commit bd973910c8
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=252313
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sys/kern/kern_descrip.c
View file

@ -3427,11 +3427,9 @@ kern_proc_filedesc_out(struct proc *p, struct sbuf *sb, ssize_t maxlen)
* re-validate and re-evaluate its properties when
* the loop continues.
*/
if (type == KF_TYPE_VNODE || type == KF_TYPE_FIFO)
FILEDESC_SUNLOCK(fdp);
error = export_fd_to_sb(data, type, i, fflags, refcnt,
offset, fd_cap_rights, kif, sb, &remainder);
if (type == KF_TYPE_VNODE || type == KF_TYPE_FIFO)
FILEDESC_SLOCK(fdp);
if (error)
break;