From b29e98fa8dfcee3b5362a9a2cb479a2379fb16da Mon Sep 17 00:00:00 2001 From: Alexander Motin Date: Fri, 20 Oct 2023 14:54:05 -0400 Subject: [PATCH] Properly pad struct tx_cpu to cache line We already use ____cacheline_aligned in many places, so add one more instead of seems arbitrary char tc_pad[8]. Reviewed-by: Brian Behlendorf Signed-off-by: Alexander Motin Sponsored by: iXsystems, Inc. Closes #15402 --- include/sys/txg_impl.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/sys/txg_impl.h b/include/sys/txg_impl.h index 45fde2e1f351..8ab7969b25be 100644 --- a/include/sys/txg_impl.h +++ b/include/sys/txg_impl.h @@ -73,8 +73,7 @@ struct tx_cpu { kcondvar_t tc_cv[TXG_SIZE]; uint64_t tc_count[TXG_SIZE]; /* tx hold count on each txg */ list_t tc_callbacks[TXG_SIZE]; /* commit cb list */ - char tc_pad[8]; /* pad to fill 3 cache lines */ -}; +} ____cacheline_aligned; /* * The tx_state structure maintains the state information about the different