system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-21 18:27:22 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

rtld: unlock bind lock when calling into crt __pthread_distribute_static_tls method

Browse source 
The method might require resolving and binding symbols, which means
recursing on the bind lock. It is safe to unlock the bind lock,
since we operate on the private object list, and user attempting to
unload an object from the list of not yet fully loaded objects caused
self-inflicted race.

It is similar to how we treat user' init/fini methods.

Reported by:	stevek
Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
This commit is contained in:
Konstantin Belousov 2023-08-18 22:52:24 +03:00
parent 64fbda90da
commit b1d3e2b771
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libexec/rtld-elf/rtld.c
View file

@ -5897,8 +5897,10 @@ distribute_static_tls(Objlist *list, RtldLockState *lockstate)
obj = elm->obj;
if (obj->marker || !obj->tls_static || obj->static_tls_copied)
continue;
lock_release(rtld_bind_lock, lockstate);
distrib(obj->tlsoffset, obj->tlsinit, obj->tlsinitsize,
obj->tlssize);
wlock_acquire(rtld_bind_lock, lockstate);
obj->static_tls_copied = true;
}
}