Use strlcpy() instead of strncpy() when copying ifname to ensure

that it is NUL terminated.  Additional NUL padding is not required
for short names.

Reported by:	Coverity
CID:		1009974
MFC after:	1 week
This commit is contained in:
Don Lewis 2016-05-15 22:31:03 +00:00
parent dc47112fa5
commit b0882deadb
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=299869

View file

@ -1592,7 +1592,7 @@ ifconfig1(const char *name,
if (IN6_IS_ADDR_SITELOCAL(&sin6->sin6_addr) && !lflag)
return (-1);
ifr.ifr_addr = *sin6;
strncpy(ifr.ifr_name, name, sizeof(ifr.ifr_name));
strlcpy(ifr.ifr_name, name, sizeof(ifr.ifr_name));
if (ioctl(s, SIOCGIFNETMASK_IN6, (char *)&ifr) < 0) {
syslog(LOG_INFO, "ioctl: SIOCGIFNETMASK_IN6");
return (-1);