system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-22 02:37:15 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

There are a couple of bugs in rev. 1.27:

Browse source 
1) The man page should describe the code, not the other way around.
2) Internal variables should not be documented or exposed, except in
   controlled circumstances (i.e. - That's what the -C flag is for).
   The variable should have been saved to the config file in save_config().
3) The next available userid doesn't get automatically updated. The
   end-result is the same (user gets added with the correct uid),
   but in an interactive session the default uid doesn't get updated in
   the display.

So,

o Use the uidstart variable instead of uuid (bug #3)
o Actually save the variable to adduser.conf (bug #2)
o (bug #1 to be fixed in an upcomming commit to adduser.conf.5)

MFC After: 2 weeks
This commit is contained in:
Mike Makonnen 2007-04-12 08:17:56 +00:00
parent f30cdb6e7d
commit ac3cd4717c
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=168656
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
usr.sbin/adduser/adduser.sh
View file

@ -199,6 +199,7 @@ save_config() {
echo "udotdir=$udotdir" >> ${ADDUSERCONF}
echo "msgfile=$msgfile" >> ${ADDUSERCONF}
echo "disableflag=$disableflag" >> ${ADDUSERCONF}
echo "uidstart=$uidstart" >> ${ADDUSERCONF}
}
# add_user
@ -453,16 +454,10 @@ get_homedir() {
# allocates one if it is not specified.
#
get_uid() {
if [ -z "$uuid" ]; then
uuid=${uidstart}
fi
uuid=${uidstart}
_input=
_prompt=
# No need to take down uids for a configuration saving run.
[ -n "$configflag" ] && return
if [ -n "$uuid" ]; then
_prompt="Uid [$uuid]: "
else