system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-10-18 06:14:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Lock and unlock sched_lock when walking through thread list, current we

Browse source 
insert kse upcall thread into thread list at mi_switch time, process lock
is not enough.
This commit is contained in:
David Xu 2003-12-07 23:47:15 +00:00
parent b01a62069f
commit a9a48d6862
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=123273
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
sys/kern/kern_sig.c
View file

@ -395,8 +395,10 @@ kern_sigaction(td, sig, act, oact, flags)
}
/* never to be seen again */
SIGDELSET(p->p_siglist, sig);
mtx_lock_spin(&sched_lock);
FOREACH_THREAD_IN_PROC(p, td0)
SIGDELSET(td0->td_siglist, sig);
mtx_unlock_spin(&sched_lock);
if (sig != SIGCONT)
/* easier in psignal */
SIGADDSET(ps->ps_sigignore, sig);
@ -1589,10 +1591,13 @@ sigtd(struct proc *p, int sig, int prop)
* way to deliver signal.
*/
signal_td = NULL;
mtx_lock_spin(&sched_lock);
FOREACH_THREAD_IN_PROC(p, td) {
if (td->td_waitset != NULL &&
SIGISMEMBER(*(td->td_waitset), sig))
SIGISMEMBER(*(td->td_waitset), sig)) {
mtx_unlock_spin(&sched_lock);
return (td);
}
if (!SIGISMEMBER(td->td_sigmask, sig)) {
if (td == curthread)
signal_td = curthread;
@ -1602,6 +1607,7 @@ sigtd(struct proc *p, int sig, int prop)
}
if (signal_td == NULL)
signal_td = FIRST_THREAD_IN_PROC(p);
mtx_unlock_spin(&sched_lock);
return (signal_td);
}
@ -1741,8 +1747,10 @@ do_tdsignal(struct thread *td, int sig, sigtarget_t target)
* XXX Should investigate leaving STOP and CONT sigs only in
* the proc's siglist.
*/
mtx_lock_spin(&sched_lock);
FOREACH_THREAD_IN_PROC(p, td0)
SIG_STOPSIGMASK(td0->td_siglist);
mtx_unlock_spin(&sched_lock);
}
if (prop & SA_STOP) {
@ -1757,8 +1765,10 @@ do_tdsignal(struct thread *td, int sig, sigtarget_t target)
(action == SIG_DFL))
return;
SIG_CONTSIGMASK(p->p_siglist);
mtx_lock_spin(&sched_lock);
FOREACH_THREAD_IN_PROC(p, td0)
SIG_CONTSIGMASK(td0->td_siglist);
mtx_unlock_spin(&sched_lock);
p->p_flag &= ~P_CONTINUED;
}