system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-10-02 22:54:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

nvmf_tcp: Correct tests for PDU direction

Browse source 
Add parentheses to ensure the correct order of operations.

Reported by:	GCC
This commit is contained in:
John Baldwin 2024-05-06 13:33:54 -07:00
parent e75a79f40b
commit a7db82cfd9
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/libnvmf/nvmf_tcp.c
View file

@ -803,7 +803,7 @@ nvmf_tcp_validate_ic_pdu(struct nvmf_association *na, struct nvmf_tcp_qpair *qp,
/* Validate pdu_type. */
/* Controllers only receive PDUs with a PDU direction of 0. */
if (na->na_controller != (ch->pdu_type & 0x01) == 0) {
if (na->na_controller != ((ch->pdu_type & 0x01) == 0)) {
na_error(na, "NVMe/TCP: Invalid PDU type %u", ch->pdu_type);
nvmf_tcp_report_error(na, qp,
NVME_TCP_TERM_REQ_FES_INVALID_HEADER_FIELD, 0, ch, pdu_len,

2
sys/dev/nvmf/nvmf_tcp.h
View file

@ -50,7 +50,7 @@ nvmf_tcp_validate_pdu_header(const struct nvme_tcp_common_pdu_hdr *ch,
/* Validate pdu_type. */
/* Controllers only receive PDUs with a PDU direction of 0. */
if (controller != (ch->pdu_type & 0x01) == 0) {
if (controller != ((ch->pdu_type & 0x01) == 0)) {
printf("NVMe/TCP: Invalid PDU type %u\n", ch->pdu_type);
*fes = NVME_TCP_TERM_REQ_FES_INVALID_HEADER_FIELD;
*fei = offsetof(struct nvme_tcp_common_pdu_hdr, pdu_type);