system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-22 18:56:38 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

libibverbs: Fix memory leak in ibv_read_sysfs_file().

Browse source 
Testing packetdrill using valgrind resulted in finding a memory leak in
ibv_read_sysfs_file(). The attached patch fixes it.

Submitted by:	tuexen@
Approved by:    hselasky (mentor)
MFC after:      1 week
Sponsored by:   Mellanox Technologies
This commit is contained in:
Slava Shwartsman 2018-12-05 13:28:17 +00:00
parent 3006180863
commit a6578a04e4
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=341540
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
contrib/ofed/libibverbs/sysfs.c
View file

@ -79,7 +79,7 @@ int ibv_read_sysfs_file(const char *dir, const char *file,
char *buf, size_t size)
{
char *path, *s;
int fd;
int ret;
size_t len;
if (asprintf(&path, "%s/%s", dir, file) < 0)
@ -89,12 +89,13 @@ int ibv_read_sysfs_file(const char *dir, const char *file,
if (*s == '/')
*s = '.';
len = size;
if (sysctlbyname(&path[1], buf, &len, NULL, 0) == -1)
return -1;
len = size;
ret = sysctlbyname(&path[1], buf, &len, NULL, 0);
free(path);
if (ret == -1)
return -1;
if (len > 0 && buf[len - 1] == '\n')
buf[--len] = '\0';