system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-22 10:48:02 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

drop GDB_LIBEXEC option (now always true)

Browse source 
In-tree gdb is essentially obsolete.  We kept it for sparc64 (because
gdb in ports lacked sparc64 support) and as a fallback for crashinfo.
gdb was installed to /libexec on all archs other than sparc64, where the
WITHOUT_GDB_LIBEXEC option was default, with gdb installed to /usr/bin.
With sparc64's retirement WITH_GDB_LIBEXEC became the default for all
architectures, but it was still possible to set it off and install gdb
into /usr/bin.

As the next step in gdb's retirement, remove the option and install gdb
only into /libexec as the crashinfo fallback. We expect users to install
the gdb port or package for debugging. The in-tree gdb lacks support for
a number of supported architectures and does not support contemporary
DWARF debug info.

Reviewed by:	jhb (earlier)
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D24227
This commit is contained in:
Ed Maste 2020-03-30 20:05:09 +00:00
parent c42a67671b
commit a52b0bb1d2
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=359457
7 changed files with 10 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ObsoleteFiles.inc
View file

@ -36,6 +36,14 @@
# xargs -n1 | sort | uniq -d;
# done
# 20200330: GDB_LIBEXEC option retired (always true)
OLD_FILES+=usr/bin/gdb
OLD_FILES+=usr/bin/gdbserver
OLD_FILES+=usr/bin/kgdb
OLD_FILES+=usr/share/man/man1/gdb.1.gz
OLD_FILES+=usr/share/man/man1/gdbserver.1.gz
OLD_FILES+=usr/share/man/man1/kgdb.1.gz
# 20200327: OCF refactoring
OLD_FILES+=usr/share/man/man9/crypto_find_driver.9
OLD_FILES+=usr/share/man/man9/crypto_register.9

6
gnu/usr.bin/gdb/Makefile
View file

@ -4,10 +4,4 @@
SUBDIR= libgdb gdb kgdb
.if ${MK_GDB_LIBEXEC} == "no"
.if exists(${.CURDIR}/gdbserver/reg-${MACHINE_CPUARCH}.c)
SUBDIR+=gdbserver
.endif
.endif
.include <bsd.subdir.mk>

2
gnu/usr.bin/gdb/Makefile.inc
View file

@ -58,7 +58,7 @@ GENSRCS+= nm.h tm.h
CFLAGS+= -DCROSS_DEBUGGER -I${BMAKE_ROOT:H:H}
GDB_SUFFIX= -${TARGET_ARCH}
MAN=
.elif ${MK_GDB_LIBEXEC} != "no"
.else
BINDIR?= /usr/libexec
MAN=
.endif

1
share/mk/src.opts.mk
View file

@ -106,7 +106,6 @@ __DEFAULT_YES_OPTIONS = \
FTP \
GAMES \
GDB \
GDB_LIBEXEC \
GNU_DIFF \
GNU_GREP \
GOOGLETEST \

11
tools/build/mk/OptionalObsoleteFiles.inc
View file

@ -2282,16 +2282,7 @@ OLD_FILES+=usr/bin/llvm-profdata
OLD_FILES+=usr/share/man/man1/llvm-cov.1.gz
.endif
.if ${MK_GDB} == no || ${MK_GDB_LIBEXEC} == yes
OLD_FILES+=usr/bin/gdb
OLD_FILES+=usr/bin/gdbserver
OLD_FILES+=usr/bin/kgdb
OLD_FILES+=usr/share/man/man1/gdb.1.gz
OLD_FILES+=usr/share/man/man1/gdbserver.1.gz
OLD_FILES+=usr/share/man/man1/kgdb.1.gz
.endif
.if ${MK_GDB} == no || ${MK_GDB_LIBEXEC} == no
.if ${MK_GDB} == no
OLD_FILES+=usr/libexec/gdb
OLD_FILES+=usr/libexec/kgdb
.endif

5
tools/build/options/WITHOUT_GDB_LIBEXEC
View file

@ -1,5 +0,0 @@
.\" $FreeBSD$
Set to install
.Xr gdb 1
into
.Pa /usr/bin .

10
tools/build/options/WITH_GDB_LIBEXEC
View file

@ -1,10 +0,0 @@
.\" $FreeBSD$
Set to install
.Xr gdb 1
into
.Pa /usr/libexec .
This permits
.Xr gdb 1
to be used as a fallback for
.Xr crashinfo 8
if a newer version is not installed.