system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-10-04 15:40:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

login: Use getpwnam_r() instead of getpwnam().

Browse source 
Since we expect the entry to still be valid after calling into PAM,
which may call getpwnam() itself, we need to use getpwnam_r().

MFC after:	1 week
Sponsored by:	Klara, Inc.
Reviewed by:	kevans, imp, allanjude, markj
Differential Revision:	https://reviews.freebsd.org/D43376
This commit is contained in:
Dag-Erling Smørgrav 2024-01-12 16:40:22 +01:00
parent e007b89e9d
commit a3d80dd8aa
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
usr.bin/login/login.c
View file

@ -110,6 +110,8 @@ static u_int timeout = 300;
/* Buffer for signal handling of timeout */
static jmp_buf timeout_buf;
char pwbuf[1024];
struct passwd pwres;
struct passwd *pwd;
static int failures;
@ -315,7 +317,7 @@ main(int argc, char *argv[])
bail(NO_SLEEP_EXIT, 1);
}
pwd = getpwnam(username);
(void)getpwnam_r(username, &pwres, pwbuf, sizeof(pwbuf), &pwd);
if (pwd != NULL && pwd->pw_uid == 0)
rootlogin = 1;
@ -338,7 +340,7 @@ main(int argc, char *argv[])
(void)setpriority(PRIO_PROCESS, 0, 0);
}
if (pwd && rval == 0)
if (pwd != NULL && rval == 0)
break;
pam_cleanup();