From 99adf661ab635a956abc2998689fd42c85f8ccc5 Mon Sep 17 00:00:00 2001 From: Elliott Mitchell Date: Thu, 9 May 2024 17:04:35 -0600 Subject: [PATCH] sys: declare bit sets unsigned Substantially reduce the number of signed/unsigned issues (warnings if enabled). While these are presently disabled for FreeBSD, being able to enable another warning would be good. Differential Revision: https://reviews.freebsd.org/D32793 Reviewed by: imp, jhibbits Pull Request: https://github.com/freebsd/freebsd-src/pull/1126 --- sys/sys/_bitset.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/sys/_bitset.h b/sys/sys/_bitset.h index 87bc722fe5f8..2b3be3bbec61 100644 --- a/sys/sys/_bitset.h +++ b/sys/sys/_bitset.h @@ -36,7 +36,7 @@ * Macros addressing word and bit within it, tuned to make compiler * optimize cases when SETSIZE fits into single machine word. */ -#define _BITSET_BITS (sizeof(long) * 8) +#define _BITSET_BITS (sizeof(unsigned long) * 8) #define __howmany(x, y) (((x) + ((y) - 1)) / (y)) @@ -44,7 +44,7 @@ #define __BITSET_DEFINE(_t, _s) \ struct _t { \ - long __bits[__bitset_words((_s))]; \ + unsigned long __bits[__bitset_words((_s))]; \ } /*