system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-08 20:26:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

change ipmi watchdog to awlays stop when system is halted

Browse Source 
That is, wd_shutdown_countdown value is ignored when halting.

A halted system should remain halted for as long as needed until
a power cycle, so the watchdog should not reset the system.
This commit is contained in:
Andriy Gapon 2023-01-03 19:26:45 +02:00
parent 90dc788982
commit 8fdb261601
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/dev/ipmi/ipmi.c
View File

@ -766,6 +766,10 @@ ipmi_shutdown_event(void *arg, int howto)
* Zero value in wd_shutdown_countdown will disable watchdog;
* Negative value in wd_shutdown_countdown will keep existing state;
*
* System halt is a special case of shutdown where wd_shutdown_countdown
* is ignored and watchdog is disabled to ensure that the system remains
* halted as requested.
*
* Revert to using a power cycle to ensure that the watchdog will
* do something useful here. Having the watchdog send an NMI
* instead is useless during shutdown, and might be ignored if an
@ -773,7 +777,7 @@ ipmi_shutdown_event(void *arg, int howto)
*/
wd_in_shutdown = true;
if (wd_shutdown_countdown == 0) {
if (wd_shutdown_countdown == 0 || (howto & RB_HALT) != 0) {
/* disable watchdog */
ipmi_set_watchdog(sc, 0);
sc->ipmi_watchdog_active = 0;