system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-10-17 13:53:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

r228827 fixed a problem where copying of NFSv4 open credentials into

Browse source 
a credential structure would corrupt it. This happened when the
p argument was != NULL. However, I now realize that the copying of
open credentials should only happen for p == NULL, since that indicates
that it is a read-ahead or write-behind. This patch fixes this.
After this commit, r228827 could be reverted, but I think the code is
clearer and safer with the patch, so I am going to leave it in.
Without this patch, it was possible that a NFSv4 VOP_SETATTR() could have
changed the credentials of the caller. This would have happened if
the process doing the VOP_SETATTR() did not have the file open, but
some other process running as a different uid had the file open for writing
at the same time.

MFC after:	5 days
This commit is contained in:
Rick Macklem 2012-02-07 16:32:43 +00:00
parent 50c8ec53f6
commit 8c9c322347
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=231133
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
sys/fs/nfsclient/nfs_clstate.c
View file

@ -559,8 +559,12 @@ nfscl_getstateid(vnode_t vp, u_int8_t *nfhp, int fhlen, u_int32_t mode,
NFSUNLOCKCLSTATE();
return (ENOENT);
}
/* for read aheads or write behinds, use the open cred */
newnfs_copycred(&op->nfso_cred, cred);
/*
* For read aheads or write behinds, use the open cred.
* A read ahead or write behind is indicated by p == NULL.
*/
if (p == NULL)
newnfs_copycred(&op->nfso_cred, cred);
}
/*