system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-22 02:37:15 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Change strmode argument type to mode_t

Browse source 
Finally, we have the correct function definition for strmode.  NetBSD/OpenBSD
did this many years ago. This code is weird sign extension safe.

Reviewed by:	imp@
Pull Request:	https://github.com/freebsd/freebsd-src/pull/493
This commit is contained in:
Alfonso Gregory 2021-06-25 11:35:14 -04:00 committed by Warner Losh
parent ed1a156b03
commit 849dcdb1c0
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
include/string.h
View file

@ -96,7 +96,13 @@ size_t strlcpy(char * __restrict, const char * __restrict, size_t);
#endif
size_t strlen(const char *) __pure;
#if __BSD_VISIBLE
void strmode(int, char *);
#ifndef _MODE_T_DECLARED
typedef __mode_t mode_t;
#define _MODE_T_DECLARED
#endif
void strmode(mode_t, char *);
#endif
char *strncat(char * __restrict, const char * __restrict, size_t);
int strncmp(const char *, const char *, size_t) __pure;

2
lib/libc/string/strmode.c
View file

@ -40,7 +40,7 @@ __FBSDID("$FreeBSD$");
#include <string.h>
void
strmode(/* mode_t */ int mode, char *p)
strmode(mode_t mode, char *p)
{
/* print type */
switch (mode & S_IFMT) {