system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-09 04:36:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fb: Check for errors from copyin()

Browse Source 
When compiling with gcc, a function annotated with __result_use_check
cannot have its return value ignored with a void cast.  So, try to
handle it.

MFC after:	1 week
This commit is contained in:
Mark Johnston 2024-01-12 10:09:22 -05:00
parent 5df041c4bb
commit 848a8bf3f4
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/dev/fb/vesa.c
View File

@ -1732,11 +1732,15 @@ set_palette(video_adapter_t *adp, int base, int count,
r = malloc(count * 3, M_DEVBUF, M_WAITOK | M_ZERO);
g = r + count;
b = g + count;
(void)copyin(red, r, count);
(void)copyin(green, g, count);
(void)copyin(blue, b, count);
if (copyin(red, r, count) != 0 ||
copyin(green, g, count) != 0 ||
copyin(blue, b, count) != 0) {
error = 1;
goto out;
}
error = vesa_bios_load_palette2(base, count, r, g, b, bits);
out:
free(r, M_DEVBUF);
return (error);