system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-10-18 14:23:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

First part of the fix for ohci_hash_find_td panic.

Browse source 
Some controllers submit bogus pointers to the Done queue.
ohci_hash_find_td fails to find these in its hash and panics. Instead of
panicing we now assume the whole done queue is lost and let the timeout
code to clean up the mess after us.
This commit is contained in:
Nick Hibma 2000-01-29 14:53:47 +00:00
parent b7598e9bd7
commit 8010b90dc6
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=56834
1 changed files with 21 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
sys/dev/usb/ohci.c
View file

@ -1102,9 +1102,24 @@ ohci_process_done(sc, done)
DPRINTFN(10,("ohci_process_done: done=0x%08lx\n", (u_long)done));
/* Reverse the done list. */
for (sdone = 0; done; done = LE(std->td.td_nexttd)) {
std = ohci_hash_find_td(sc, done);
/* Reverse the done list and store the reversed list in sdone */
sdone = NULL;
for (; done; done = LE(std->td.td_nexttd)) {
std = ohci_hash_find_td(sc, done & LE(OHCI_TAILMASK));
if (std == NULL) {
#ifdef OHCI_DEBUG
DPRINTF(("%s: Invalid done queue 0x%08x",
USBDEVNAME(sc->sc_bus.bdev), done));
ohci_dumpregs(sc);
#endif
/* XXX Should we compare the list of active TDs with
* the list of TDs queued at EDs to handle the ones that
* are not listed on any of the ED queues and therefore
* must be finished?
*/
return;
}
std->dnext = sdone;
sdone = std;
}
@ -1572,7 +1587,9 @@ ohci_hash_find_td(sc, a)
if (std->physaddr == a)
return (std);
panic("ohci_hash_find_td: addr 0x%08lx not found\n", (u_long)a);
DPRINTF(("%s: ohci_hash_find_td: addr 0x%08lx not found\n",
USBDEVNAME(sc->sc_bus.bdev), (u_long) a));
return NULL;
}
void