system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-10-06 16:40:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

ipfilter: Avoid allocating a new ipf token when not needed

Browse source 
Only allocate a new ipftoken_t if one cannot be found. This eliminates
allocating unnecessary token structures that will never be used when
performing simple lookups for existing token structures.

MFC after:	2 weeks
This commit is contained in:
Cy Schubert 2023-09-12 13:29:29 -07:00
parent 81c5f0fac9
commit 7f5e3b9fa3
1 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
sys/netpfil/ipfilter/netinet/fil.c
View file

@ -7460,10 +7460,6 @@ ipf_token_find(ipf_main_softc_t *softc, int type, int uid, void *ptr)
{
ipftoken_t *it, *new;
KMALLOC(new, ipftoken_t *);
if (new != NULL)
bzero((char *)new, sizeof(*new));
WRITE_ENTER(&softc->ipf_tokens);
for (it = softc->ipf_token_head; it != NULL; it = it->ipt_next) {
if ((ptr == it->ipt_ctx) && (type == it->ipt_type) &&
@ -7472,6 +7468,10 @@ ipf_token_find(ipf_main_softc_t *softc, int type, int uid, void *ptr)
}
if (it == NULL) {
KMALLOC(new, ipftoken_t *);
if (new != NULL)
bzero((char *)new, sizeof(*new));
it = new;
new = NULL;
if (it == NULL) {
@ -7483,11 +7483,6 @@ ipf_token_find(ipf_main_softc_t *softc, int type, int uid, void *ptr)
it->ipt_type = type;
it->ipt_ref = 1;
} else {
if (new != NULL) {
KFREE(new);
new = NULL;
}
if (it->ipt_complete > 0)
it = NULL;
else