ctladm: don't require the use of "-p" with "port -r", part 2

* Remove a now superfluous FALLTHROUGH hint
* Don't specify "-p" with an empty argument in the tests

Reported by:	jhb
MFC after:	1 week
MFC with:	edbd489d09
This commit is contained in:
Alan Somers 2024-07-04 14:32:24 -06:00
parent 09164454aa
commit 7f50027321
2 changed files with 1 additions and 2 deletions

View file

@ -592,7 +592,6 @@ cctl_port(int fd, int argc, char **argv, char *combinedopt)
}
#endif
case CCTL_PORT_MODE_REMOVE:
/* FALLTHROUGH */
case CCTL_PORT_MODE_CREATE: {
bzero(&req, sizeof(req));
strlcpy(req.driver, driver, sizeof(req.driver));

View file

@ -62,7 +62,7 @@ cleanup() {
;;
"iscsi")
TARGET=`awk '/target:/ {print $2}' port-create.txt`
ctladm port -r -d $driver -p "$PORTNUM" -O cfiscsi_portal_group_tag=$PGTAG -O cfiscsi_target=$TARGET
ctladm port -r -d $driver -O cfiscsi_portal_group_tag=$PGTAG -O cfiscsi_target=$TARGET
;;
esac
fi