system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-22 10:48:02 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

ath: Handle errors from copyout() in ath_rate_fetch_node_stats()

Browse source 
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D43096
This commit is contained in:
Mark Johnston 2023-12-25 20:35:43 -05:00
parent 2a1d50fc12
commit 711880597c
1 changed files with 17 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
sys/dev/ath/ath_rate/sample/sample.c
View file

@ -1433,11 +1433,13 @@ ath_rate_fetch_node_stats(struct ath_softc *sc, struct ath_node *an,
const HAL_RATE_TABLE *rt = sc->sc_currates;
struct ath_rateioctl_tlv av;
struct ath_rateioctl_rt *tv;
int y;
int error, y;
int o = 0;
ATH_NODE_LOCK_ASSERT(an);
error = 0;
/*
* Ensure there's enough space for the statistics.
*/
@ -1478,9 +1480,13 @@ ath_rate_fetch_node_stats(struct ath_softc *sc, struct ath_node *an,
*/
av.tlv_id = ATH_RATE_TLV_RATETABLE;
av.tlv_len = sizeof(struct ath_rateioctl_rt);
copyout(&av, rs->buf + o, sizeof(struct ath_rateioctl_tlv));
error = copyout(&av, rs->buf + o, sizeof(struct ath_rateioctl_tlv));
if (error != 0)
goto out;
o += sizeof(struct ath_rateioctl_tlv);
copyout(tv, rs->buf + o, sizeof(struct ath_rateioctl_rt));
error = copyout(tv, rs->buf + o, sizeof(struct ath_rateioctl_rt));
if (error != 0)
goto out;
o += sizeof(struct ath_rateioctl_rt);
/*
@ -1488,18 +1494,22 @@ ath_rate_fetch_node_stats(struct ath_softc *sc, struct ath_node *an,
*/
av.tlv_id = ATH_RATE_TLV_SAMPLENODE;
av.tlv_len = sizeof(struct sample_node);
copyout(&av, rs->buf + o, sizeof(struct ath_rateioctl_tlv));
error = copyout(&av, rs->buf + o, sizeof(struct ath_rateioctl_tlv));
if (error != 0)
goto out;
o += sizeof(struct ath_rateioctl_tlv);
/*
* Copy the statistics over to the provided buffer.
*/
copyout(sn, rs->buf + o, sizeof(struct sample_node));
error = copyout(sn, rs->buf + o, sizeof(struct sample_node));
if (error != 0)
goto out;
o += sizeof(struct sample_node);
out:
free(tv, M_TEMP);
return (0);
return (error);
}
static void