system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-10-04 23:50:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not leak vnode lock when msdosfs mount is updated and specified

Browse source 
device is different from the device used to the original mount.

Note that update_mp does not need devvp locked, and pmp->pm_devvp cannot
be freed meantime.

Reported and tested by:	pho
MFC after:	3 weeks
This commit is contained in:
Konstantin Belousov 2010-03-02 17:24:33 +00:00
parent e1c6ef6aa4
commit 6c0358cc98
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=204589
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
sys/fs/msdosfs/msdosfs_vfsops.c
View file

@ -383,10 +383,9 @@ msdosfs_mount(struct mount *mp)
pmp = VFSTOMSDOSFS(mp);
#endif
} else {
if (devvp != pmp->pm_devvp)
error = EINVAL; /* XXX needs translation */
else
vput(devvp);
if (devvp != pmp->pm_devvp)
return (EINVAL); /* XXX needs translation */
}
if (error) {
vrele(devvp);