mirror of
https://github.com/freebsd/freebsd-src
synced 2024-10-15 04:43:53 +00:00
Delay calling yp_malloc_dnsent() until after some additional sanity
checks to avoid leaking memory on error returns. Reported by: Coverity CID: 1007416 MFC after: 1 week
This commit is contained in:
parent
a23f17d3b1
commit
5fb70b0cae
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=300636
|
@ -489,9 +489,6 @@ yp_async_lookup_addr(struct svc_req *rqstp, char *addr, int af)
|
|||
yp_find_dnsqent(svcudp_get_xid(rqstp->rq_xprt),BY_RPC_XID) != NULL)
|
||||
return(YP_TRUE);
|
||||
|
||||
if ((q = yp_malloc_dnsent()) == NULL)
|
||||
return(YP_YPERR);
|
||||
|
||||
switch (af) {
|
||||
case AF_INET:
|
||||
if (inet_aton(addr, (struct in_addr *)uaddr) != 1)
|
||||
|
@ -516,6 +513,9 @@ yp_async_lookup_addr(struct svc_req *rqstp, char *addr, int af)
|
|||
return(YP_YPERR);
|
||||
}
|
||||
|
||||
if ((q = yp_malloc_dnsent()) == NULL)
|
||||
return(YP_YPERR);
|
||||
|
||||
if (debug)
|
||||
yp_error("DNS address is: %s", buf);
|
||||
|
||||
|
|
Loading…
Reference in a new issue