system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-21 10:19:04 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

sh: Don't add something to a null pointer

Browse source 
Pointer arithmetic on a null pointer is undefined behavior.

The bug can be reproduced by running bin/sh/tests/builtins/wait6.0 with
UBSAN.

Reported by:	Mark Millard
Reviewed by:	imp
Differential Revision:	https://reviews.freebsd.org/D34011
This commit is contained in:
Jilles Tjoelker 2022-01-23 22:15:57 +01:00
parent ddf312e8d7
commit 5a1a07f2a0
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
bin/sh/jobs.c
View file

@ -587,6 +587,8 @@ waitcmdloop(struct job *job)
return retval;
}
} else {
if (njobs == 0)
return 0;
for (jp = jobtab ; jp < jobtab + njobs; jp++)
if (jp->used && jp->state == JOBDONE) {
if (! iflag || ! jp->changed)