libsecureboot: avoid set but not used errors

Reviewed by:	stevek
This commit is contained in:
Simon J. Gerraty 2023-06-29 23:52:17 -07:00
parent fcc8d72702
commit 56f3f2d249
2 changed files with 17 additions and 12 deletions

View File

@ -464,20 +464,22 @@ verify_asc(const char *sigfile, int flags)
size_t n;
unsigned char *fdata, *sdata;
size_t fbytes, sbytes;
fdata = NULL;
if ((sdata = read_file(sigfile, &sbytes))) {
n = strlcpy(pbuf, sigfile, sizeof(pbuf));
if ((cp = strrchr(pbuf, '.')))
*cp = '\0';
if ((fdata = read_file(pbuf, &fbytes))) {
if (openpgp_verify(pbuf, fdata, fbytes, sdata,
sbytes, flags)) {
free(fdata);
fdata = NULL;
if (n < sizeof(pbuf)) {
if ((cp = strrchr(pbuf, '.')))
*cp = '\0';
if ((fdata = read_file(pbuf, &fbytes))) {
if (openpgp_verify(pbuf, fdata, fbytes, sdata,
sbytes, flags)) {
free(fdata);
fdata = NULL;
}
}
}
} else
fdata = NULL;
}
free(sdata);
return (fdata);
}

View File

@ -241,11 +241,14 @@ x509_cn_get(br_x509_certificate *xc, char *buf, size_t len)
mc.vtable->start_cert(&mc.vtable, xc->data_len);
mc.vtable->append(&mc.vtable, xc->data, xc->data_len);
mc.vtable->end_cert(&mc.vtable);
/* we don' actually care about cert status - just its name */
/* we don't actually care about cert status - just its name */
err = mc.vtable->end_chain(&mc.vtable);
if (!cn.status)
if (!cn.status) {
buf = NULL;
if (err == 0) /* keep compiler happy */
buf = NULL;
}
return (buf);
}