system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-09-06 17:18:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

cam: change xpt_clone_path to return int

Browse source 
xpt_clone_path originally returned a cam_status, but it doesn't do I/O
and should return an errno instead. I added it last year and it's only
used in one place. It's not yet documented, so no doc changes are
nneeded.

Reviewed by:		scottl@, mav@
Sponsored by:		Netflix
Differential Revision:	https://reviews.freebsd.org/D30884
This commit is contained in:
Warner Losh 2021-06-28 16:04:02 -06:00
parent 2b09870238
commit 50aa1daf14
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
sys/cam/cam_xpt.c
View file

@ -3669,14 +3669,14 @@ xpt_compile_path(struct cam_path *new_path, struct cam_periph *perph,
return (status);
}
cam_status
int
xpt_clone_path(struct cam_path **new_path_ptr, struct cam_path *path)
{
struct cam_path *new_path;
new_path = (struct cam_path *)malloc(sizeof(*path), M_CAMPATH, M_NOWAIT);
if (new_path == NULL)
return(CAM_RESRC_UNAVAIL);
return (ENOMEM);
*new_path = *path;
if (path->bus != NULL)
xpt_acquire_bus(path->bus);
@ -3685,7 +3685,7 @@ xpt_clone_path(struct cam_path **new_path_ptr, struct cam_path *path)
if (path->device != NULL)
xpt_acquire_device(path->device);
*new_path_ptr = new_path;
return (CAM_REQ_CMP);
return (0);
}
void
@ -4397,7 +4397,7 @@ xpt_async(u_int32_t async_code, struct cam_path *path, void *async_arg)
return;
}
if (xpt_clone_path(&ccb->ccb_h.path, path) != CAM_REQ_CMP) {
if (xpt_clone_path(&ccb->ccb_h.path, path) != 0) {
xpt_print(path, "Can't allocate path to send %s\n",
xpt_async_string(async_code));
xpt_free_ccb(ccb);

2
sys/cam/cam_xpt.h
View file

@ -138,7 +138,7 @@ cam_status xpt_compile_path(struct cam_path *new_path,
path_id_t path_id,
target_id_t target_id,
lun_id_t lun_id);
cam_status xpt_clone_path(struct cam_path **new_path,
int xpt_clone_path(struct cam_path **new_path,
struct cam_path *path);
void xpt_release_path(struct cam_path *path);