mirror of
https://github.com/freebsd/freebsd-src
synced 2024-10-04 15:40:44 +00:00
Fix snprintf truncation in telnet
Building telnet with clang 18 results in the following warning:
contrib/telnet/telnet/telnet.c:231:5: error: 'snprintf' will always be truncated; specified size is 10, but format string expands to at least 11 [-Werror,-Wformat-truncation]
231 | snprintf(temp2, sizeof(temp2), "%c%c%c%c....%c%c", IAC, SB, TELOPT_COMPORT,
| ^
The temp2 buffer is 10 chars, while the format string also consists of
10 chars. Therefore, snprintf(3) will truncate the last character, 'SE'
(end sub negotation) in this case.
Bump the buffer to 11 chars to avoid truncation.
MFC after: 3 days
(cherry picked from commit c794d18822
)
This commit is contained in:
parent
4d9951cbb6
commit
4f3aa626f6
|
@ -208,7 +208,7 @@ unsigned char ComPortBaudRate[256];
|
|||
void
|
||||
DoBaudRate(char *arg)
|
||||
{
|
||||
char *temp, temp2[10];
|
||||
char *temp, temp2[11];
|
||||
int i;
|
||||
uint32_t baudrate;
|
||||
|
||||
|
|
Loading…
Reference in a new issue