system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-23 19:28:36 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

ptrace tests: Add a test using PROC_REAP_KILL to kill a traced debuggee

Browse source 
This exercises the bug fix in commit 9241ebc796
("thread_single(9): decline external requests for traced or debugger-stopped procs").

Reviewed by:	kib
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D44564
This commit is contained in:
Mark Johnston 2024-03-31 14:11:47 -04:00
parent d68c68693e
commit 43b4da4411
1 changed files with 47 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
tests/sys/kern/ptrace_test.c
View file

@ -4368,6 +4368,52 @@ ATF_TC_BODY(ptrace__PT_SC_REMOTE_getpid, tc)
ATF_REQUIRE(ptrace(PT_DETACH, fpid, (caddr_t)1, 0) != -1);
}
/*
* Ensure that procctl(PROC_REAP_KILL) won't block forever waiting for a target
* process that stopped to report its status to a debugger.
*/
ATF_TC_WITHOUT_HEAD(ptrace__reap_kill_stopped);
ATF_TC_BODY(ptrace__reap_kill_stopped, tc)
{
struct procctl_reaper_kill prk;
pid_t debuggee, wpid;
int error, status;
REQUIRE_EQ(procctl(P_PID, getpid(), PROC_REAP_ACQUIRE, NULL), 0);
debuggee = fork();
ATF_REQUIRE(debuggee >= 0);
if (debuggee == 0) {
trace_me();
for (;;)
sleep(10);
_exit(0);
}
wpid = waitpid(debuggee, &status, 0);
REQUIRE_EQ(wpid, debuggee);
ATF_REQUIRE(WIFSTOPPED(status));
REQUIRE_EQ(WSTOPSIG(status), SIGSTOP);
/* Resume the child and ask it to stop during syscall exits. */
ATF_REQUIRE(ptrace(PT_TO_SCX, debuggee, (caddr_t)1, 0) != -1);
/* Give the debuggee some time to go to sleep. */
usleep(100000);
/*
* Kill the child process. procctl() may attempt to stop the target
* process to prevent it from adding new children to the reaper subtree,
* and this should not conflict with the child stopping itself for the
* debugger.
*/
memset(&prk, 0, sizeof(prk));
prk.rk_sig = SIGTERM;
error = procctl(P_PID, getpid(), PROC_REAP_KILL, &prk);
REQUIRE_EQ(error, 0);
REQUIRE_EQ(1, prk.rk_killed);
REQUIRE_EQ(-1, prk.rk_fpid);
}
ATF_TP_ADD_TCS(tp)
{
ATF_TP_ADD_TC(tp, ptrace__parent_wait_after_trace_me);
@ -4434,6 +4480,7 @@ ATF_TP_ADD_TCS(tp)
ATF_TP_ADD_TC(tp, ptrace__procdesc_wait_child);
ATF_TP_ADD_TC(tp, ptrace__procdesc_reparent_wait_child);
ATF_TP_ADD_TC(tp, ptrace__PT_SC_REMOTE_getpid);
ATF_TP_ADD_TC(tp, ptrace__reap_kill_stopped);
return (atf_no_error());
}