system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-10-18 06:14:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

The file vnode passed to VOP_LINK() should now be locked before the call.

Browse source
This commit is contained in:
Don Lewis 2002-09-19 13:34:50 +00:00
parent fa288043e2
commit 394739140c
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=103637
1 changed files with 7 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
share/man/man9/VOP_LINK.9
View file

@ -56,15 +56,9 @@ The pathname info should NOT be released on exit because it is done
by the caller.
The directory and file vnodes should NOT be released on exit.
.Sh LOCKS
The directory,
.Fa dvp
is locked on entry and should remain locked on return.
The file
.Fa vp
is not locked on entry and should remain that way on return.
If your VOP code locks
.Fa vp ,
it must be sure to unlock prior to returning.
.Xr VOP_LINK 9
expects the directory and file vnodes to be locked on entry and will leave
the vnodes locked on return.
.Sh RETURN VALUES
Zero is returned if the file was linked successfully, otherwise an
error is returned.
@ -77,23 +71,12 @@ vop_link(struct vnode *dvp, struct vnode *vp, struct componentname *cnp)
if (vp->v_mount != dvp->v_mount)
return (EXDEV);
if (vp != dvp && (error = VOP_LOCK(vp))) {
goto out2;
}
/*
* now that we've locked vp, we have to use out1 instead of out2
*/
if (vp would have too many links)
return (EMLINK);
if (vp would have too many links) {
error = EMLINK;
goto out1;
}
if (vp is immutable) {
error = EPERM;
goto out1;
}
if (vp is immutable)
return (EPERM);
/*
* Increment link count of vp and write back the on-disc version of it.
@ -107,11 +90,6 @@ vop_link(struct vnode *dvp, struct vnode *vp, struct componentname *cnp)
...;
}
out1:
if (vp != dvp)
VOP_UNLOCK(vp);
out2:
return error;
}
.Ed