system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-21 02:06:37 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

hostname: avoid strcpy() overlap in -d flag handling

Browse source 
We don't need the strcpy() anyways, just use a pointer to the hostname
buffer and move it forward for `hostname -d`.

Sponsored by:	Klara, Inc.
This commit is contained in:
Kyle Evans 2021-09-25 00:00:31 -05:00
parent 43880c511c
commit 33c1e7271a
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
bin/hostname/hostname.c
View file

@ -57,7 +57,7 @@ int
main(int argc, char *argv[])
{
int ch, sflag, dflag;
char *p, hostname[MAXHOSTNAMELEN];
char hostname[MAXHOSTNAMELEN], *hostp, *p;
sflag = 0;
dflag = 0;
@ -90,6 +90,7 @@ main(int argc, char *argv[])
if (sethostname(*argv, (int)strlen(*argv)))
err(1, "sethostname");
} else {
hostp = hostname;
if (gethostname(hostname, (int)sizeof(hostname)))
err(1, "gethostname");
if (sflag) {
@ -99,9 +100,9 @@ main(int argc, char *argv[])
} else if (dflag) {
p = strchr(hostname, '.');
if (p != NULL)
strcpy(hostname, ++p);
hostp = p + 1;
}
(void)printf("%s\n", hostname);
(void)printf("%s\n", hostp);
}
exit(0);
}