From 2fe0ea732498348055db2ae0bca3e1b2d3eeeb47 Mon Sep 17 00:00:00 2001 From: Jilles Tjoelker Date: Tue, 26 Dec 2017 16:20:38 +0000 Subject: [PATCH] nandtool: Add missing mode for open() with O_CREAT If O_CREAT is given, open() needs a mode argument. Follow the umask by passing 0666. Reviewed by: imp MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D13607 --- usr.sbin/nandtool/nand_read.c | 2 +- usr.sbin/nandtool/nand_readoob.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/nandtool/nand_read.c b/usr.sbin/nandtool/nand_read.c index d84d424a5094..395b0c3fa7f5 100644 --- a/usr.sbin/nandtool/nand_read.c +++ b/usr.sbin/nandtool/nand_read.c @@ -52,7 +52,7 @@ int nand_read(struct cmd_param *params) } if ((out = param_get_string(params, "out"))) { - out_fd = open(out, O_WRONLY|O_CREAT); + out_fd = open(out, O_WRONLY|O_CREAT, 0666); if (out_fd == -1) { perrorf("Cannot open %s for writing", out); return (1); diff --git a/usr.sbin/nandtool/nand_readoob.c b/usr.sbin/nandtool/nand_readoob.c index 6d253f9db53d..6c5bb372c3e0 100644 --- a/usr.sbin/nandtool/nand_readoob.c +++ b/usr.sbin/nandtool/nand_readoob.c @@ -59,7 +59,7 @@ int nand_read_oob(struct cmd_param *params) } if ((out = param_get_string(params, "out"))) { - if ((fd_out = open(out, O_WRONLY | O_CREAT)) == -1) { + if ((fd_out = open(out, O_WRONLY | O_CREAT, 0666)) == -1) { perrorf("Cannot open %s", out); ret = 1; goto out;