system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-09-06 17:18:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

When taking a snapshot on a UFS/FFS filesystem, it must be mounted.

Browse source 
The "update" mount option must be specified when the "snapshot"
mount option is used. Return EINVAL if the "snapshot" option is
specified without the "update" option also requested.

Reported by:  Robert Morris
Reviewed by:  kib
PR:           265362
MFC after:    2 weeks
Sponsored by: The FreeBSD Foundation
This commit is contained in:
Kirk McKusick 2022-09-27 08:57:30 -07:00
parent 3247bc7cd6
commit 27d673fbbb
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
sys/ufs/ffs/ffs_vfsops.c
View file

@ -413,8 +413,11 @@ ffs_mount(struct mount *mp)
/*
* If this is a snapshot request, take the snapshot.
*/
if (mp->mnt_flag & MNT_SNAPSHOT)
if (mp->mnt_flag & MNT_SNAPSHOT) {
if ((mp->mnt_flag & MNT_UPDATE) == 0)
return (EINVAL);
return (ffs_snapshot(mp, fspec));
}
/*
* Must not call namei() while owning busy ref.