system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-22 02:37:15 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

ifconfig: skip calling fnmatch once the result no longer matters

Browse source 
Because fnmatch has no side effects, we can safely avoid calling fnmatch
if the end result does not matter anyway (the compiler cannot see this,
so it calls fnmatch in the event it has side-effects).

Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/747
This commit is contained in:
Alfonso Gregory 2023-06-27 16:18:55 -06:00 committed by Warner Losh
parent ef747607ea
commit 21c32cebf8
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
sbin/ifconfig/ifconfig.c
View file

@ -910,11 +910,11 @@ group_member(const char *ifname, const char *match, const char *nomatch)
matched = false;
nomatched = true;
for (ifg = ifgr.ifgr_groups; ifg && len >= sizeof(*ifg); ifg++) {
len -= sizeof(struct ifg_req);
if (match)
matched |= !fnmatch(match, ifg->ifgrq_group, 0);
if (nomatch)
nomatched &= fnmatch(nomatch, ifg->ifgrq_group, 0);
len -= sizeof(*ifg);
if (match && !matched)
matched = !fnmatch(match, ifg->ifgrq_group, 0);
if (nomatch && nomatched)
nomatched = fnmatch(nomatch, ifg->ifgrq_group, 0);
}
free(ifgr.ifgr_groups);