system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-10-03 15:15:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

tws: fix "set but not used" in the tws driver

Browse source 
With __diagused, these warnings were still emitted since INVARIANTS was
defined but TWS_DEBUG was not.

Fixes:  a21f086a33 ("Fix "set but not used" in the tws driver")
Differential Revision:	https://reviews.freebsd.org/D33784
This commit is contained in:
Robert Wing 2022-01-09 14:28:08 -09:00
parent 3455c738ac
commit 174d86a01b
3 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sys/dev/tws/tws.c
View file

@ -349,7 +349,7 @@ tws_detach(device_t dev)
{
struct tws_softc *sc = device_get_softc(dev);
int i;
u_int32_t reg __diagused;
u_int32_t reg __tws_debug;
TWS_TRACE_DEBUG(sc, "entry", 0, 0);

2
sys/dev/tws/tws_hdm.c
View file

@ -82,7 +82,7 @@ void tws_display_ctlr_info(struct tws_softc *sc);
int
tws_init_ctlr(struct tws_softc *sc)
{
u_int64_t reg __diagused;
u_int64_t reg __tws_debug;
u_int32_t regh, regl;
TWS_TRACE_DEBUG(sc, "entry", sc, sc->is64bit);

2
sys/dev/tws/tws_services.h
View file

@ -61,10 +61,12 @@ void tws_init_qs(struct tws_softc *sc);
#endif
#ifdef TWS_TRACE_DEBUG_ON
#define __tws_debug
#define TWS_TRACE_DEBUG(sc, desc, val1, val2) \
tws_trace(__FILE__, __func__, __LINE__, sc, desc, \
(u_int64_t)val1, (u_int64_t)val2)
#else
#define __tws_debug __unused
#define TWS_TRACE_DEBUG(sc, desc, val1, val2)
#endif