system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-10-15 21:05:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

adaspindown: check disk power mode before sending IDLE command

Browse source 
If a disk is already in STANDBY mode, then setting IDLE mode can
actually spin it up.

Reviewed by:	mav
MFC after:	4 weeks
Differential Revision:	https://reviews.freebsd.org/D33588
This commit is contained in:
Andriy Gapon 2021-12-24 11:02:22 +02:00
parent 184c63db3c
commit 15910dc0bc
1 changed files with 47 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
sys/cam/ata/ata_da.c
View file

@ -3611,6 +3611,7 @@ adaspindown(uint8_t cmd, int flags)
struct ada_softc *softc;
struct ccb_ataio local_ccb;
int error;
int mode;
CAM_PERIPH_FOREACH(periph, &adadriver) {
/* If we paniced with lock held - not recurse here. */
@ -3626,6 +3627,52 @@ adaspindown(uint8_t cmd, int flags)
continue;
}
/*
* Additionally check if we would spin up the drive instead of
* spinning it down.
*/
if (cmd == ATA_IDLE_IMMEDIATE) {
memset(&local_ccb, 0, sizeof(local_ccb));
xpt_setup_ccb(&local_ccb.ccb_h, periph->path,
CAM_PRIORITY_NORMAL);
local_ccb.ccb_h.ccb_state = ADA_CCB_DUMP;
cam_fill_ataio(&local_ccb, 0, NULL, CAM_DIR_NONE,
0, NULL, 0, ada_default_timeout * 1000);
ata_28bit_cmd(&local_ccb, ATA_CHECK_POWER_MODE,
0, 0, 0);
local_ccb.cmd.flags |= CAM_ATAIO_NEEDRESULT;
error = cam_periph_runccb((union ccb *)&local_ccb,
adaerror, /*cam_flags*/0,
/*sense_flags*/ SF_NO_RECOVERY | SF_NO_RETRY,
softc->disk->d_devstat);
if (error != 0) {
xpt_print(periph->path,
"Failed to read current power mode\n");
} else {
mode = local_ccb.res.sector_count;
#ifdef DIAGNOSTIC
if (bootverbose) {
xpt_print(periph->path,
"disk power mode 0x%02x\n", mode);
}
#endif
switch (mode) {
case 0x00:
case 0x01:
if (bootverbose) {
xpt_print(periph->path,
"already spun down\n");
}
cam_periph_unlock(periph);
continue;
default:
break;
}
}
}
if (bootverbose)
xpt_print(periph->path, "spin-down\n");