system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-09-06 17:18:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Free the memory allocated to trackbuf before exiting, it might fix a potential

Browse source 
memory leak.

Submitted by:	trix@juniper.net
MFC after:	2 weeks.
Differential Revision:	https://reviews.freebsd.org/D9856
This commit is contained in:
Marcelo Araujo 2017-05-03 13:57:31 +00:00
parent 83fd8885c4
commit 049e195404
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=317742
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
usr.sbin/fdread/fdread.c
View file

@ -184,6 +184,7 @@ doread(int fd, FILE *of, const char *_devname)
if (rv == 0) {
/* EOF? */
warnx("premature EOF after %u bytes", nbytes);
free(trackbuf);
return (EX_OK);
}
if ((unsigned)rv == tracksize) {
@ -215,6 +216,7 @@ doread(int fd, FILE *of, const char *_devname)
if (!quiet)
putc('\n', stderr);
perror("non-IO error");
free(trackbuf);
return (EX_OSERR);
}
if (ioctl(fd, FD_GSTAT, &fdcs) == -1)
@ -233,6 +235,7 @@ doread(int fd, FILE *of, const char *_devname)
if (!recover) {
if (!quiet)
putc('\n', stderr);
free(trackbuf);
return (EX_IOERR);
}
memset(trackbuf, fillbyte, secsize);
@ -284,6 +287,7 @@ doread(int fd, FILE *of, const char *_devname)
continue;
}
}
free(trackbuf);
if (!quiet) {
putc('\n', stderr);
if (nerrs)