system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-22 18:56:38 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fix an obvious 'is odd' check.

Browse source 
len % 1 is always true. Fix StrHexToBytes to do a proper odd length
check. This was only called by DevPathFromTextGenericPath,
ConvertFromTextVendor and DevPathFromTextMAC, which we've not had
a need to actually use just yet.

Submitted by: David Binderman
PR: 229718
This commit is contained in:
Warner Losh 2018-07-12 16:19:17 +00:00
parent 0a2c13d333
commit 03307d7ac3
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=336220
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/libefivar/uefi-dplib.h
View file

@ -576,7 +576,7 @@ StrHexToBytes(const char *str, size_t len, uint8_t *buf, size_t buflen)
/*
* Sanity check preconditions.
*/
if (buflen != len / 2 || (len % 1) == 1)
if (buflen != len / 2 || (len % 2) == 1)
return 1;
for (i = 0; i < len; i += 2) {
if (!isxdigit(str[i]) || !isxdigit(str[i + 1]))