system/coreutils
system/coreutils
1
0
Fork 0
mirror of https://github.com/uutils/coreutils synced 2024-10-02 22:13:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

kill: ignore signal case on -s

Browse source
This commit is contained in:
Haisham 2024-04-14 23:13:17 +05:00 committed by Ben Wiederhake
parent 524be6e4ae
commit b617876372
2 changed files with 36 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/uu/kill/src/kill.rs
View file

@ -190,7 +190,8 @@ fn list(signals: &Vec<String>) {
}
fn parse_signal_value(signal_name: &str) -> UResult<usize> {
let optional_signal_value = signal_by_name_or_value(signal_name);
let signal_name_upcase = signal_name.to_uppercase();
let optional_signal_value = signal_by_name_or_value(&signal_name_upcase);
match optional_signal_value {
Some(x) => Ok(x),
None => Err(USimpleError::new(

34
tests/by-util/test_kill.rs
View file

@ -236,6 +236,17 @@ fn test_kill_with_signal_name_new_form() {
assert_eq!(target.wait_for_signal(), Some(libc::SIGKILL));
}
#[test]
fn test_kill_with_signal_name_new_form_ignore_case() {
let mut target = Target::new();
new_ucmd!()
.arg("-s")
.arg("KiLl")
.arg(format!("{}", target.pid()))
.succeeds();
assert_eq!(target.wait_for_signal(), Some(libc::SIGKILL));
}
#[test]
fn test_kill_with_signal_prefixed_name_new_form() {
let mut target = Target::new();
@ -247,6 +258,29 @@ fn test_kill_with_signal_prefixed_name_new_form() {
assert_eq!(target.wait_for_signal(), Some(libc::SIGKILL));
}
#[test]
fn test_kill_with_signal_prefixed_name_new_form_ignore_case() {
let mut target = Target::new();
new_ucmd!()
.arg("-s")
.arg("SiGKiLl")
.arg(format!("{}", target.pid()))
.succeeds();
assert_eq!(target.wait_for_signal(), Some(libc::SIGKILL));
}
#[test]
fn test_kill_with_signal_name_new_form_unknown_must_match_input_case() {
let target = Target::new();
new_ucmd!()
.arg("-s")
.arg("IaMnOtAsIgNaL") // spell-checker:disable-line
.arg(format!("{}", target.pid()))
.fails()
.stderr_contains("unknown signal")
.stderr_contains("IaMnOtAsIgNaL"); // spell-checker:disable-line
}
#[test]
fn test_kill_no_pid_provided() {
// spell-checker:disable-line