mirror of
https://github.com/uutils/coreutils
synced 2024-10-06 16:09:08 +00:00
[mktemp] implement mktemp
This commit is contained in:
parent
dae64b5277
commit
58d1d66d16
|
@ -16,6 +16,7 @@ unix = [
|
|||
"kill",
|
||||
"logname",
|
||||
"mkfifo",
|
||||
"mktemp",
|
||||
"mv",
|
||||
"nice",
|
||||
"nohup",
|
||||
|
@ -118,6 +119,7 @@ link = { optional=true, path="src/link" }
|
|||
ln = { optional=true, path="src/ln" }
|
||||
logname = { optional=true, path="src/logname" }
|
||||
mkdir = { optional=true, path="src/mkdir" }
|
||||
mktemp = { optional=true, path="src/mktemp" }
|
||||
mkfifo = { optional=true, path="src/mkfifo" }
|
||||
mv = { optional=true, path="src/mv" }
|
||||
nice = { optional=true, path="src/nice" }
|
||||
|
|
2
Makefile
2
Makefile
|
@ -59,6 +59,7 @@ PROGS := \
|
|||
link \
|
||||
ln \
|
||||
mkdir \
|
||||
mktemp \
|
||||
nl \
|
||||
nproc \
|
||||
od \
|
||||
|
@ -143,6 +144,7 @@ TEST_PROGS := \
|
|||
link \
|
||||
ln \
|
||||
mkdir \
|
||||
mktemp \
|
||||
mv \
|
||||
nl \
|
||||
paste \
|
||||
|
|
|
@ -165,7 +165,7 @@ To do
|
|||
- join
|
||||
- ls
|
||||
- mknod
|
||||
- mktemp
|
||||
- mktemp (almost done, some options are not working)
|
||||
- mv (almost done, one more option)
|
||||
- numfmt
|
||||
- od (in progress, needs lots of work)
|
||||
|
|
15
src/mktemp/Cargo.toml
Normal file
15
src/mktemp/Cargo.toml
Normal file
|
@ -0,0 +1,15 @@
|
|||
[package]
|
||||
name = "mktemp"
|
||||
version = "0.0.1"
|
||||
authors = []
|
||||
|
||||
[lib]
|
||||
name = "uu_mktemp"
|
||||
path = "mktemp.rs"
|
||||
|
||||
[dependencies]
|
||||
uucore = { path="../uucore" }
|
||||
getopts = "*"
|
||||
libc = "*"
|
||||
rand = "0.3"
|
||||
tempfile = {git = "https://github.com/Stebalien/tempfile.git"}
|
209
src/mktemp/mktemp.rs
Normal file
209
src/mktemp/mktemp.rs
Normal file
|
@ -0,0 +1,209 @@
|
|||
#![crate_name = "uu_mktemp"]
|
||||
|
||||
/*
|
||||
* This file is part of the uutils coreutils package.
|
||||
*
|
||||
* (c) Sunrin SHIMURA
|
||||
*
|
||||
* For the full copyright and license information, please view the LICENSE
|
||||
* file that was distributed with this source code.
|
||||
*/
|
||||
|
||||
extern crate getopts;
|
||||
extern crate libc;
|
||||
extern crate tempfile;
|
||||
extern crate rand;
|
||||
|
||||
#[macro_use]
|
||||
extern crate uucore;
|
||||
|
||||
use std::env;
|
||||
use std::io::Write;
|
||||
use std::path::{PathBuf, is_separator};
|
||||
use std::mem::forget;
|
||||
use std::iter;
|
||||
|
||||
use rand::Rng;
|
||||
use tempfile::NamedTempFileOptions;
|
||||
|
||||
static NAME: &'static str = "mktemp";
|
||||
static VERSION: &'static str = env!("CARGO_PKG_VERSION");
|
||||
static DEFAULT_TEMPLATE: &'static str = "tmp.XXXXXXXXXX";
|
||||
|
||||
|
||||
|
||||
pub fn uumain(args: Vec<String>) -> i32 {
|
||||
let mut opts = getopts::Options::new();
|
||||
opts.optflag("d", "directory", "Make a directory instead of a file");
|
||||
opts.optflag("u", "dry-run", "do not create anything; merely print a name (unsafe)");
|
||||
opts.optflag("q", "quiet", "Fail silently if an error occurs.");
|
||||
opts.optopt("", "suffix", "append SUFF to TEMPLATE; SUFF must not contain a path separator. This option is implied if TEMPLATE does not end with X.", "SUFF");
|
||||
opts.optopt("p", "tmpdir", "interpret TEMPLATE relative to DIR; if DIR is not specified, use $TMPDIR if set, else /tmp. With this option, TEMPLATE must not be an absolute name; unlike with -t, TEMPLATE may contain slashes, but mktemp creates only the final component", "DIR");
|
||||
// deprecated option of GNU coreutils
|
||||
// opts.optflag("t", "", "Generate a template (using the supplied prefix and TMPDIR if set) to create a filename template");
|
||||
opts.optflag("", "help", "Print this help and exit");
|
||||
opts.optflag("", "version", "print the version and exit");
|
||||
|
||||
|
||||
// >> early return options
|
||||
let matches = match opts.parse(&args[1..]) {
|
||||
Ok(m) => m,
|
||||
Err(f) => crash!(1, "Invalid options\n{}", f)
|
||||
};
|
||||
|
||||
if matches.opt_present("quiet") {
|
||||
// TODO: close stderror. `crash!` macro always write output to stderror
|
||||
crash!(1, "quiet option is not supported yet.");
|
||||
};
|
||||
|
||||
if args.len() == 1 || matches.opt_present("help") {
|
||||
print_help(&opts);
|
||||
return 0;
|
||||
}
|
||||
if matches.opt_present("version") {
|
||||
println!("{} {}", NAME, VERSION);
|
||||
return 0;
|
||||
}
|
||||
|
||||
if 1 < matches.free.len() {
|
||||
crash!(1, "Too many templates");
|
||||
}
|
||||
// <<
|
||||
|
||||
let make_dir = matches.opt_present("directory");
|
||||
let dry_run = matches.opt_present("dry-run");
|
||||
let suffix_opt = matches.opt_str("suffix");
|
||||
|
||||
|
||||
let template = if matches.free.is_empty() {
|
||||
DEFAULT_TEMPLATE
|
||||
} else {
|
||||
&matches.free[0][..]
|
||||
};
|
||||
|
||||
let (prefix, rand, suffix) = match parse_template(template) {
|
||||
Some((p, r, s)) => match suffix_opt {
|
||||
Some(suf) => if s == "" {
|
||||
(p, r, suf)
|
||||
} else {
|
||||
crash!(1, "Template should end with 'X' when you specify suffix option.")
|
||||
},
|
||||
None => (p, r, s.to_string())
|
||||
},
|
||||
None => ("",0, "".to_string())
|
||||
};
|
||||
|
||||
if rand < 3 {
|
||||
crash!(1, "Too few 'X's in template")
|
||||
}
|
||||
|
||||
if suffix.chars().any(|c| is_separator(c)) {
|
||||
crash!(1, "suffix cannot contain any path separators");
|
||||
}
|
||||
|
||||
|
||||
let tmpdir = match matches.opt_str("tmpdir") {
|
||||
Some(s) => {
|
||||
if PathBuf::from(prefix).is_absolute() {
|
||||
crash!(1, "template must not be an absolute path when tempdir is specified.");
|
||||
}
|
||||
PathBuf::from(s)
|
||||
|
||||
},
|
||||
None => env::temp_dir()
|
||||
};
|
||||
|
||||
if dry_run {
|
||||
dry_exec(tmpdir, prefix, rand, &suffix)
|
||||
} else {
|
||||
exec(tmpdir, prefix, rand , &suffix, make_dir)
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
fn print_help(opts: &getopts::Options) {
|
||||
let usage = format!(" Create a temporary file or directory, safely, and print its name.
|
||||
TEMPLATE must contain at least 3 consecutive 'X's in last component.
|
||||
If TEMPLATE is not specified, use {}, and --tmpdir is implied", DEFAULT_TEMPLATE);
|
||||
|
||||
println!("{} {}", NAME, VERSION);
|
||||
println!("SYNOPSIS");
|
||||
println!(" {} [OPTION]... [FILE]", NAME);
|
||||
println!("Usage:");
|
||||
print!("{}", opts.usage(&usage[..]));
|
||||
}
|
||||
|
||||
fn parse_template(temp :&str) -> Option<(&str, usize, &str)> {
|
||||
let right = match temp.rfind('X') {
|
||||
Some(r) => r+1,
|
||||
None => return None
|
||||
};
|
||||
let left = temp[..right].rfind(|c| c != 'X').map_or(0, |i| i + 1);
|
||||
let prefix = &temp[..left];
|
||||
let rand = right - left;
|
||||
let suffix = &temp[right..];
|
||||
Some((prefix, rand, suffix))
|
||||
}
|
||||
|
||||
pub fn dry_exec(mut tmpdir: PathBuf, prefix: &str, rand: usize, suffix: &str) -> i32 {
|
||||
let len = prefix.len() + suffix.len() + rand;
|
||||
let mut buf = String::with_capacity(len);
|
||||
buf.push_str(prefix);
|
||||
buf.extend(iter::repeat('X').take(rand));
|
||||
buf.push_str(suffix);
|
||||
|
||||
// Randomize.
|
||||
unsafe {
|
||||
// We guarantee utf8.
|
||||
let bytes = &mut buf.as_mut_vec()[prefix.len()..prefix.len() + rand];
|
||||
rand::thread_rng().fill_bytes(bytes);
|
||||
for byte in bytes.iter_mut() {
|
||||
*byte = match *byte % 62 {
|
||||
v @ 0...9 => (v + '0' as u8),
|
||||
v @ 10...35 => (v - 10 + 'a' as u8),
|
||||
v @ 36...61 => (v - 36 + 'A' as u8),
|
||||
_ => unreachable!(),
|
||||
}
|
||||
}
|
||||
}
|
||||
tmpdir.push(String::from(buf));
|
||||
println!("{}", tmpdir.display());
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
||||
|
||||
|
||||
fn exec(tmpdir: PathBuf, prefix: &str, rand: usize, suffix: &str, make_dir: bool) -> i32 {
|
||||
// TODO: respect make_dir option
|
||||
if make_dir {
|
||||
crash!(1, "Directory option is not supported yet. Sorry.");
|
||||
}
|
||||
|
||||
|
||||
let tmpfile = NamedTempFileOptions::new()
|
||||
.prefix(prefix)
|
||||
.rand_bytes(rand)
|
||||
.suffix(suffix)
|
||||
// CAUTION: Creating tempfile regardless of dry_run option.
|
||||
// if dry_run options is given, we delete the created file.
|
||||
.create_in(tmpdir);
|
||||
|
||||
let tmpfile = match tmpfile {
|
||||
Ok(f) => f,
|
||||
Err(_) => crash!(1, "failed to create tempfile")
|
||||
};
|
||||
|
||||
let tmpname = tmpfile
|
||||
.path()
|
||||
.to_string_lossy()
|
||||
.to_string();
|
||||
|
||||
println!("{}", tmpname);
|
||||
|
||||
// CAUTION: Not to call `drop` of tmpfile, which removes the tempfile,
|
||||
// I call a dengeros function `forget`.
|
||||
forget(tmpfile);
|
||||
|
||||
return 0;
|
||||
}
|
137
tests/mktemp.rs
Normal file
137
tests/mktemp.rs
Normal file
|
@ -0,0 +1,137 @@
|
|||
extern crate tempdir;
|
||||
|
||||
use tempdir::TempDir;
|
||||
use std::env::set_var;
|
||||
|
||||
#[macro_use]
|
||||
mod common;
|
||||
|
||||
use common::util::*;
|
||||
|
||||
static UTIL_NAME: &'static str = "mktemp";
|
||||
|
||||
static TEST_TEMPLATE1: &'static str = "tempXXXXXX";
|
||||
static TEST_TEMPLATE2: &'static str = "temp";
|
||||
static TEST_TEMPLATE3: &'static str = "tempX";
|
||||
static TEST_TEMPLATE4: &'static str = "tempXX";
|
||||
static TEST_TEMPLATE5: &'static str = "tempXXX";
|
||||
static TEST_TEMPLATE6: &'static str = "tempXXXlate";
|
||||
static TEST_TEMPLATE7: &'static str = "XXXtemplate";
|
||||
#[cfg(unix)]
|
||||
static TEST_TEMPLATE8: &'static str = "tempXXXla/te";
|
||||
#[cfg(windows)]
|
||||
static TEST_TEMPLATE8: &'static str = "tempXXXla\\te";
|
||||
|
||||
const TMPDIR: &'static str = "TMPDIR";
|
||||
|
||||
|
||||
#[test]
|
||||
fn test_mktemp_mktemp() {
|
||||
let ts = TestSet::new(UTIL_NAME);
|
||||
|
||||
let pathname = ts.fixtures.as_string();
|
||||
set_var(TMPDIR, pathname);
|
||||
|
||||
let exit_success1 = ts.util_cmd_keepenv().arg(TEST_TEMPLATE1).run().success;
|
||||
let exit_success2 = ts.util_cmd_keepenv().arg(TEST_TEMPLATE2).run().success;
|
||||
let exit_success3 = ts.util_cmd_keepenv().arg(TEST_TEMPLATE3).run().success;
|
||||
let exit_success4 = ts.util_cmd_keepenv().arg(TEST_TEMPLATE4).run().success;
|
||||
let exit_success5 = ts.util_cmd_keepenv().arg(TEST_TEMPLATE5).run().success;
|
||||
let exit_success6 = ts.util_cmd_keepenv().arg(TEST_TEMPLATE6).run().success;
|
||||
let exit_success7 = ts.util_cmd_keepenv().arg(TEST_TEMPLATE7).run().success;
|
||||
let exit_success8 = ts.util_cmd_keepenv().arg(TEST_TEMPLATE8).run().success;
|
||||
|
||||
|
||||
assert!(exit_success1);
|
||||
assert!(!exit_success2);
|
||||
assert!(!exit_success3);
|
||||
assert!(!exit_success4);
|
||||
assert!(exit_success5);
|
||||
assert!(exit_success6);
|
||||
assert!(exit_success7);
|
||||
assert!(!exit_success8);
|
||||
}
|
||||
|
||||
// TODO: test directory option when implemented
|
||||
#[test]
|
||||
fn test_mktemp_dry_run() {
|
||||
let ts = TestSet::new(UTIL_NAME);
|
||||
|
||||
let pathname = ts.fixtures.as_string();
|
||||
set_var(TMPDIR, pathname);
|
||||
|
||||
let exit_success1 = ts.util_cmd_keepenv().arg("-u").arg(TEST_TEMPLATE1).run().success;
|
||||
let exit_success2 = ts.util_cmd_keepenv().arg("-u").arg(TEST_TEMPLATE2).run().success;
|
||||
let exit_success3 = ts.util_cmd_keepenv().arg("-u").arg(TEST_TEMPLATE3).run().success;
|
||||
let exit_success4 = ts.util_cmd_keepenv().arg("-u").arg(TEST_TEMPLATE4).run().success;
|
||||
let exit_success5 = ts.util_cmd_keepenv().arg("-u").arg(TEST_TEMPLATE5).run().success;
|
||||
let exit_success6 = ts.util_cmd_keepenv().arg("-u").arg(TEST_TEMPLATE6).run().success;
|
||||
let exit_success7 = ts.util_cmd_keepenv().arg("-u").arg(TEST_TEMPLATE7).run().success;
|
||||
let exit_success8 = ts.util_cmd_keepenv().arg("-u").arg(TEST_TEMPLATE8).run().success;
|
||||
|
||||
|
||||
assert!(exit_success1);
|
||||
assert!(!exit_success2);
|
||||
assert!(!exit_success3);
|
||||
assert!(!exit_success4);
|
||||
assert!(exit_success5);
|
||||
assert!(exit_success6);
|
||||
assert!(exit_success7);
|
||||
assert!(!exit_success8);
|
||||
}
|
||||
|
||||
// TOOD: test quiet option when correctry implemented
|
||||
|
||||
#[test]
|
||||
fn test_mktemp_suffix() {
|
||||
let ts = TestSet::new(UTIL_NAME);
|
||||
|
||||
let pathname = ts.fixtures.as_string();
|
||||
set_var(TMPDIR, pathname);
|
||||
|
||||
let exit_success1 = ts.util_cmd_keepenv().arg("--suffix").arg("suf").arg(TEST_TEMPLATE1).run().success;
|
||||
let exit_success2 = ts.util_cmd_keepenv().arg("--suffix").arg("suf").arg(TEST_TEMPLATE2).run().success;
|
||||
let exit_success3 = ts.util_cmd_keepenv().arg("--suffix").arg("suf").arg(TEST_TEMPLATE3).run().success;
|
||||
let exit_success4 = ts.util_cmd_keepenv().arg("--suffix").arg("suf").arg(TEST_TEMPLATE4).run().success;
|
||||
let exit_success5 = ts.util_cmd_keepenv().arg("--suffix").arg("suf").arg(TEST_TEMPLATE5).run().success;
|
||||
let exit_success6 = ts.util_cmd_keepenv().arg("--suffix").arg("suf").arg(TEST_TEMPLATE6).run().success;
|
||||
let exit_success7 = ts.util_cmd_keepenv().arg("--suffix").arg("suf").arg(TEST_TEMPLATE7).run().success;
|
||||
let exit_success8 = ts.util_cmd_keepenv().arg("--suffix").arg("suf").arg(TEST_TEMPLATE8).run().success;
|
||||
|
||||
|
||||
assert!(exit_success1);
|
||||
assert!(!exit_success2);
|
||||
assert!(!exit_success3);
|
||||
assert!(!exit_success4);
|
||||
assert!(exit_success5);
|
||||
assert!(!exit_success6);
|
||||
assert!(!exit_success7);
|
||||
assert!(!exit_success8);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_mktemp_tmpdir() {
|
||||
let ts = TestSet::new(UTIL_NAME);
|
||||
|
||||
let path = TempDir::new_in(ts.fixtures.as_string(), UTIL_NAME).unwrap();
|
||||
let pathname = path.path().as_os_str();
|
||||
|
||||
let exit_success1 = ts.util_cmd().arg("-p").arg(pathname).arg(TEST_TEMPLATE1).run().success;
|
||||
let exit_success2 = ts.util_cmd().arg("-p").arg(pathname).arg(TEST_TEMPLATE2).run().success;
|
||||
let exit_success3 = ts.util_cmd().arg("-p").arg(pathname).arg(TEST_TEMPLATE3).run().success;
|
||||
let exit_success4 = ts.util_cmd().arg("-p").arg(pathname).arg(TEST_TEMPLATE4).run().success;
|
||||
let exit_success5 = ts.util_cmd().arg("-p").arg(pathname).arg(TEST_TEMPLATE5).run().success;
|
||||
let exit_success6 = ts.util_cmd().arg("-p").arg(pathname).arg(TEST_TEMPLATE6).run().success;
|
||||
let exit_success7 = ts.util_cmd().arg("-p").arg(pathname).arg(TEST_TEMPLATE7).run().success;
|
||||
let exit_success8 = ts.util_cmd().arg("-p").arg(pathname).arg(TEST_TEMPLATE8).run().success;
|
||||
|
||||
|
||||
assert!(exit_success1);
|
||||
assert!(!exit_success2);
|
||||
assert!(!exit_success3);
|
||||
assert!(!exit_success4);
|
||||
assert!(exit_success5);
|
||||
assert!(exit_success6);
|
||||
assert!(exit_success7);
|
||||
assert!(!exit_success8);
|
||||
}
|
Loading…
Reference in a new issue