system/coreutils
system/coreutils
1
0
Fork 0
mirror of https://github.com/uutils/coreutils synced 2024-10-07 08:29:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests/test: Ensure the test fixture files have the expected gid

Browse source 
On some platforms (mostly the BSDs) the test fixture files copied to the
/tmp directory will have a different gid than the current egid (due to
the sticky bit set on the /tmp directory). Fix this before running the
"test" command.
This commit is contained in:
Nathan Houghton 2023-10-22 10:22:36 -07:00 committed by Sylvestre Ledru
parent 356023b055
commit 1915e3c438
1 changed files with 37 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
tests/by-util/test_test.rs
View file

@ -667,7 +667,7 @@ fn test_nonexistent_file_not_owned_by_euid() {
}
#[test]
#[cfg(all(not(windows), not(target_os = "freebsd")))]
#[cfg(not(windows))]
fn test_file_not_owned_by_euid() {
new_ucmd!()
.args(&["-f", "/bin/sh", "-a", "!", "-O", "/bin/sh"])
@ -675,9 +675,32 @@ fn test_file_not_owned_by_euid() {
}
#[test]
#[cfg(all(not(windows), not(target_os = "freebsd")))]
#[cfg(not(windows))]
fn test_file_owned_by_egid() {
new_ucmd!().args(&["-G", "regular_file"]).succeeds();
let scene = TestScenario::new(util_name!());
let at = &scene.fixtures;
// On some platforms (mostly the BSDs) the test fixture files copied to the
// /tmp directory will have a different gid than the current egid (due to
// the sticky bit set on the /tmp directory). Fix this before running the
// test command.
use std::ffi::CString;
use std::os::unix::ffi::OsStrExt;
use std::os::unix::fs::MetadataExt;
use uucore::process::getegid;
let metadata = at.metadata("regular_file");
let file_gid = metadata.gid();
let user_gid = getegid();
if user_gid != file_gid {
let file_uid = metadata.uid();
let path = CString::new(at.plus("regular_file").as_os_str().as_bytes()).expect("bad path");
let r = unsafe { libc::chown(path.as_ptr().into(), file_uid, user_gid) };
assert_ne!(r, -1);
}
scene.ucmd().args(&["-G", "regular_file"]).succeeds();
}
#[test]
@ -690,10 +713,19 @@ fn test_nonexistent_file_not_owned_by_egid() {
}
#[test]
#[cfg(all(not(windows), not(target_os = "freebsd")))]
#[cfg(not(windows))]
fn test_file_not_owned_by_egid() {
let target_file = if cfg!(target_os = "freebsd") {
// The coreutils test runner user has a primary group id of "wheel",
// which matches the gid of /bin/sh, so use /sbin/shutdown which has gid
// of "operator".
"/sbin/shutdown"
} else {
"/bin/sh"
};
new_ucmd!()
.args(&["-f", "/bin/sh", "-a", "!", "-G", "/bin/sh"])
.args(&["-f", target_file, "-a", "!", "-G", target_file])
.succeeds();
}