mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager
synced 2024-07-21 18:24:49 +00:00
1cab6367b2
G_PARAM_CONSTRUCT cause to explicitly initialize the property during object construction. This is an unnecessary overhead that we can easily avoid. The overhead is because G_PARAM_CONSTRUCT parameters are always set with g_object_set() before calling constructed(). Even if they are not specified during g_object_new(), in which case it calls set with the property's default value. This also requires g_object_new() to iterate all properties to find and sort the construct properties. NMSetting are supposed to be simple classes. They don't need to have their properties initialized before object construction completes. Especially if the default values are NULL or zero, in which case there is nothing to do. If the default value is not NULL or zero, we need to initialize the field instead in the nm_setting*_init() function.
158 lines
3.6 KiB
C
158 lines
3.6 KiB
C
// SPDX-License-Identifier: LGPL-2.1+
|
|
/*
|
|
* Copyright (C) 2019 Red Hat, Inc.
|
|
*/
|
|
|
|
#include "nm-default.h"
|
|
|
|
#include "nm-setting-ovs-dpdk.h"
|
|
|
|
#include "nm-connection-private.h"
|
|
#include "nm-setting-connection.h"
|
|
#include "nm-setting-private.h"
|
|
|
|
/**
|
|
* SECTION:nm-setting-ovs-dpdk
|
|
* @short_description: Describes connection properties for Open vSwitch DPDK interfaces.
|
|
*
|
|
* The #NMSettingOvsDpdk object is a #NMSetting subclass that describes properties
|
|
* necessary for Open vSwitch interfaces of type "dpdk".
|
|
**/
|
|
|
|
/*****************************************************************************/
|
|
|
|
NM_GOBJECT_PROPERTIES_DEFINE_BASE (
|
|
PROP_DEVARGS,
|
|
);
|
|
|
|
/**
|
|
* NMSettingOvsDpdk:
|
|
*
|
|
* OvsDpdk Link Settings
|
|
*/
|
|
struct _NMSettingOvsDpdk {
|
|
NMSetting parent;
|
|
|
|
char *devargs;
|
|
};
|
|
|
|
struct _NMSettingOvsDpdkClass {
|
|
NMSettingClass parent;
|
|
};
|
|
|
|
G_DEFINE_TYPE (NMSettingOvsDpdk, nm_setting_ovs_dpdk, NM_TYPE_SETTING)
|
|
|
|
/*****************************************************************************/
|
|
|
|
/**
|
|
* nm_setting_ovs_dpdk_get_devargs:
|
|
* @self: the #NMSettingOvsDpdk
|
|
*
|
|
* Returns: the #NMSettingOvsDpdk:devargs property of the setting
|
|
*
|
|
* Since: 1.20
|
|
**/
|
|
const char *
|
|
nm_setting_ovs_dpdk_get_devargs (NMSettingOvsDpdk *self)
|
|
{
|
|
g_return_val_if_fail (NM_IS_SETTING_OVS_DPDK (self), NULL);
|
|
|
|
return self->devargs;
|
|
}
|
|
|
|
/*****************************************************************************/
|
|
|
|
static void
|
|
get_property (GObject *object, guint prop_id,
|
|
GValue *value, GParamSpec *pspec)
|
|
{
|
|
NMSettingOvsDpdk *self = NM_SETTING_OVS_DPDK (object);
|
|
|
|
switch (prop_id) {
|
|
case PROP_DEVARGS:
|
|
g_value_set_string (value, self->devargs);
|
|
break;
|
|
default:
|
|
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
|
|
break;
|
|
}
|
|
}
|
|
|
|
static void
|
|
set_property (GObject *object, guint prop_id,
|
|
const GValue *value, GParamSpec *pspec)
|
|
{
|
|
NMSettingOvsDpdk *self = NM_SETTING_OVS_DPDK (object);
|
|
|
|
switch (prop_id) {
|
|
case PROP_DEVARGS:
|
|
g_free (self->devargs);
|
|
self->devargs = g_value_dup_string (value);
|
|
break;
|
|
default:
|
|
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
|
|
break;
|
|
}
|
|
}
|
|
|
|
/*****************************************************************************/
|
|
|
|
static void
|
|
nm_setting_ovs_dpdk_init (NMSettingOvsDpdk *self)
|
|
{
|
|
}
|
|
|
|
/**
|
|
* nm_setting_ovs_dpdk_new:
|
|
*
|
|
* Creates a new #NMSettingOvsDpdk object with default values.
|
|
*
|
|
* Returns: (transfer full): the new empty #NMSettingOvsDpdk object
|
|
*
|
|
* Since: 1.20
|
|
**/
|
|
NMSetting *
|
|
nm_setting_ovs_dpdk_new (void)
|
|
{
|
|
return (NMSetting *) g_object_new (NM_TYPE_SETTING_OVS_DPDK, NULL);
|
|
}
|
|
|
|
static void
|
|
finalize (GObject *object)
|
|
{
|
|
NMSettingOvsDpdk *self = NM_SETTING_OVS_DPDK (object);
|
|
|
|
g_free (self->devargs);
|
|
|
|
G_OBJECT_CLASS (nm_setting_ovs_dpdk_parent_class)->finalize (object);
|
|
}
|
|
|
|
static void
|
|
nm_setting_ovs_dpdk_class_init (NMSettingOvsDpdkClass *klass)
|
|
{
|
|
GObjectClass *object_class = G_OBJECT_CLASS (klass);
|
|
NMSettingClass *setting_class = NM_SETTING_CLASS (klass);
|
|
|
|
object_class->set_property = set_property;
|
|
object_class->get_property = get_property;
|
|
object_class->finalize = finalize;
|
|
|
|
/**
|
|
* NMSettingOvsDpdk:devargs:
|
|
*
|
|
* Open vSwitch DPDK device arguments.
|
|
*
|
|
* Since: 1.20
|
|
**/
|
|
obj_properties[PROP_DEVARGS] =
|
|
g_param_spec_string (NM_SETTING_OVS_DPDK_DEVARGS, "", "",
|
|
NULL,
|
|
G_PARAM_READWRITE |
|
|
NM_SETTING_PARAM_INFERRABLE |
|
|
G_PARAM_STATIC_STRINGS);
|
|
|
|
g_object_class_install_properties (object_class, _PROPERTY_ENUMS_LAST, obj_properties);
|
|
|
|
_nm_setting_class_commit (setting_class, NM_META_SETTING_TYPE_OVS_DPDK);
|
|
}
|