NetworkManager/libnm-core
Thomas Haller 85566e46d9 libnm-core: fix crash in update-secrets when trying to clear all settings without providing a connection variant
When the caller wants to clear all settings (thus providing
@setting_name NULL), a NM_VARIANT_TYPE_CONNECTION variant is
expected. This would lead to a crash when constructing the
@error literal due to uninitialized @key.

Clang also warns:

    Making all in .
    make[4]: Entering directory `./NetworkManager/libnm-core'
      CC       nm-connection.lo
    ../libnm-core/nm-connection.c:1016:25: error: variable 'key' is uninitialized when used here [-Werror,-Wuninitialized]
                                                 key);
                                                 ^~~
    ../libnm-core/nm-connection.c:962:17: note: initialize the variable 'key' to silence this warning
            const char *key;
                           ^
                            = NULL
    1 error generated.

Fixes: acf86f68b3
Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-09-22 16:16:41 +02:00
..
tests libnm-core: fix crash in update-secrets when trying to clear all settings without providing a connection variant 2014-09-22 16:16:41 +02:00
crypto.c libnm-core: replace GByteArray with pointer + length in some APIs 2014-09-04 09:20:11 -04:00
crypto.h libnm-core: replace GByteArray with pointer + length in some APIs 2014-09-04 09:20:11 -04:00
crypto_gnutls.c libnm-core: replace GByteArray with pointer + length in some APIs 2014-09-04 09:20:11 -04:00
crypto_nss.c libnm-core: replace GByteArray with pointer + length in some APIs 2014-09-04 09:20:11 -04:00
Makefile.am libnm: port to GDBus 2014-09-18 11:51:09 -04:00
Makefile.libnm-core libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-connection.c libnm-core: fix crash in update-secrets when trying to clear all settings without providing a connection variant 2014-09-22 16:16:41 +02:00
nm-connection.h libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-core-internal.h libnm: port to GDBus 2014-09-18 11:51:09 -04:00
nm-dbus-interface.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-property-compare.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-property-compare.h libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-8021x.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-8021x.h libnm-core: change DBUS_TYPE_G_UCHAR_ARRAY properties to G_TYPE_BYTES 2014-09-04 09:20:11 -04:00
nm-setting-adsl.c libnm-core: simplify _nm_register_setting(), register error types too 2014-09-04 09:18:44 -04:00
nm-setting-adsl.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-bluetooth.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-bluetooth.h libnm-core: change all mac-address properties to G_TYPE_STRING 2014-09-04 09:20:10 -04:00
nm-setting-bond.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-bond.h libnm-core: drop :interface-name properties on virtual NMSetting types 2014-09-04 09:18:44 -04:00
nm-setting-bridge-port.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-bridge-port.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-bridge.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-bridge.h libnm-core: change all mac-address properties to G_TYPE_STRING 2014-09-04 09:20:10 -04:00
nm-setting-cdma.c libnm-core: simplify _nm_register_setting(), register error types too 2014-09-04 09:18:44 -04:00
nm-setting-cdma.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-connection.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-connection.h libnm-core: normalize slave-type and slave-settings of connections 2014-08-22 15:24:31 +02:00
nm-setting-dcb.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-dcb.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-generic.c libnm-core: simplify _nm_register_setting(), register error types too 2014-09-04 09:18:44 -04:00
nm-setting-generic.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-gsm.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-gsm.h libnm-core: drop previously-deprecated NMSetting properties 2014-09-04 09:17:37 -04:00
nm-setting-infiniband.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-infiniband.h libnm-core: change all mac-address properties to G_TYPE_STRING 2014-09-04 09:20:10 -04:00
nm-setting-ip4-config.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-ip4-config.h libnm-core: improve NMSettingIP4Config / NMSettingIP6Config property types 2014-09-04 09:20:11 -04:00
nm-setting-ip6-config.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-ip6-config.h libnm-core: improve NMSettingIP4Config / NMSettingIP6Config property types 2014-09-04 09:20:11 -04:00
nm-setting-olpc-mesh.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-olpc-mesh.h libnm-core: change DBUS_TYPE_G_UCHAR_ARRAY properties to G_TYPE_BYTES 2014-09-04 09:20:11 -04:00
nm-setting-ppp.c libnm-core: simplify _nm_register_setting(), register error types too 2014-09-04 09:18:44 -04:00
nm-setting-ppp.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-pppoe.c libnm-core: simplify _nm_register_setting(), register error types too 2014-09-04 09:18:44 -04:00
nm-setting-pppoe.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-private.h libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-serial.c libnm-core: simplify _nm_register_setting(), register error types too 2014-09-04 09:18:44 -04:00
nm-setting-serial.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-team-port.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-team-port.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-team.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-team.h libnm-core: drop :interface-name properties on virtual NMSetting types 2014-09-04 09:18:44 -04:00
nm-setting-vlan.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-vlan.h libnm-core: drop :interface-name properties on virtual NMSetting types 2014-09-04 09:18:44 -04:00
nm-setting-vpn.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-vpn.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-wimax.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-wimax.h libnm-core: change all mac-address properties to G_TYPE_STRING 2014-09-04 09:20:10 -04:00
nm-setting-wired.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-wired.h libnm-core: change list-of-string and array-of-string properties to G_TYPE_STRV 2014-09-04 09:20:10 -04:00
nm-setting-wireless-security.c libnm-core: change list-of-string and array-of-string properties to G_TYPE_STRV 2014-09-04 09:20:10 -04:00
nm-setting-wireless-security.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-wireless.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-wireless.h libnm-core: change DBUS_TYPE_G_UCHAR_ARRAY properties to G_TYPE_BYTES 2014-09-04 09:20:11 -04:00
nm-setting.c libnm-core: don't return with a value in function returning void 2014-09-19 09:36:24 +02:00
nm-setting.h libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-simple-connection.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-simple-connection.h libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-utils-private.h libnm: port to GDBus 2014-09-18 11:51:09 -04:00
nm-utils.c libnm: port to GDBus 2014-09-18 11:51:09 -04:00
nm-utils.h libnm: port to GDBus 2014-09-18 11:51:09 -04:00
nm-version.h.in libnm: add libnm/libnm-core (part 1) 2014-08-01 14:34:04 -04:00
nm-vpn-dbus-interface.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00