system/NetworkManager
system/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager synced 2024-07-21 18:24:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
19903 commits 392 branches 552 tags 172 MiB
Commit graph

65 commits

Author SHA1 Message Date
Beniamino Galvani 8ffa22d10d dhcp: dhclient: set type 0 for printable client IDs 
The documentation for the ipv4.dhcp-client-id property says:

 If the property is not a hex string it is considered as a
 non-hardware-address client ID and the 'type' field is set to 0.

However, currently we set the client-id without the leading zero byte
in the dhclient configuration and thus dhclient sends the first string
character as type and the remainder as client-id content. Looking
through git history, the dhclient plugin has always behaved this way
even if the intent was clearly that string client-id had to be zero
padded (this is evident by looking at
nm_dhcp_utils_client_id_string_to_bytes()). The internal plugin
instead sends the correct client-id with zero type.

Change the dhclient plugin to honor the documented behavior and add
the leading zero byte when the client-id is a string.

This commit introduces a change in behavior for users that have
dhcp=dhclient and have a plain string (not hexadecimal) set in
ipv4.dhcp-client-id, as NM will send a different client-id possibly
changing the IP address returned by the server.

https://bugzilla.gnome.org/show_bug.cgi?id=793957
 2018-03-15 17:25:27 +01:00
Thomas Haller 28da0154fc all: drop trailing spaces 2018-02-07 13:32:04 +01:00
Beniamino Galvani 4fce1b90bf release: update NEWS 2017-11-10 16:15:23 +01:00
Beniamino Galvani affeeb5a23 NEWS: update for a release candidate 2017-11-03 15:46:02 +01:00
Thomas Haller 4d47d5bf51 release: update NEWS 2017-05-10 13:19:16 +02:00
Lubomir Rintel b5d63b8005 release: update NEWS 2017-04-20 17:02:31 +02:00
Lubomir Rintel 092cf11226 NEWS: update for a release candidate 2017-03-28 15:39:21 +02:00
Lubomir Rintel da32a9f8bd NEWS: update for a development snapshot 2017-03-23 17:41:04 +01:00
Thomas Haller 37b659f75f NEWS: update 2017-02-14 18:00:18 +01:00
Thomas Haller a101e0dc6a release: update NEWS 2017-01-25 17:38:43 +01:00
Lubomir Rintel 57c084a611 NEWS: move the more important entries upwards 2017-01-23 18:42:55 +01:00
Lubomir Rintel c7b525f83e release: update NEWS 
Co-authored-by: Thomas Haller <thaller@redhat.com>
 2017-01-17 14:15:37 +01:00
Thomas Haller a4b6a57688 NEWS: belatedly add news entry for th/preserve-fake-perm-hwaddr-bgo772880 
This was already part of 1.5.2-dev.
 2016-12-16 10:12:51 +01:00
Thomas Haller 7041e4d2ed NEWS: add entry about th/sysctl-ifname-race-bgo775613 branch 2016-12-16 10:04:35 +01:00
Lubomir Rintel 8afbf3d2b7 NEWS: update for a development snapshot 2016-12-15 20:29:47 +01:00
Lubomir Rintel bcb158e1bc NEWS: update for a development snapshot 2016-11-03 17:56:13 +01:00
Thomas Haller fae5ecec5a device: change default value for cloned-mac-address to "preserve" (bgo#770611) 
Long ago before commit 1b49f94, NetworkManager did not touch the
MAC address at all. Since 0.8.2 NetworkManager would modify the
MAC address, and eventually it would reset the permanent MAC address
of the device.

This prevents a user from externally setting the MAC address via tools
like macchanger and rely on NetworkManager not to reset it to the
permanent MAC address. This is considered a security regression in
bgo#708820.

This only changed with commit 9a354cd and 1.4.0. Since then it is possible
to configure "cloned-mac-address=preserve", which instead uses the "initial"
MAC address when the device activates.
That also changed that the "initial" MAC address is the address which was
externally configured on the device as last. In other words, the
"initial" MAC address is picked up from external changes, unless it
was NetworkManager itself who configured the address when activating a
connection.

However, in absence of an explicit configuration the default for
"cloned-mac-address" is still "permanent". Meaning, the user has to
explicitly configure that NetworkManager should not touch the MAC address.
It makes sense to change the upstream default to "preserve". Although this
is a change in behavior since 0.8.2, it seems a better default.

This change has the drastic effect that all the existing connections
out there with "cloned-mac-address=$(nil)" change behavior after upgrade.
I think most users won't notice, because their devices have the permanent
address set by default anyway. I would think that there are few users
who intentionally configured "cloned-mac-address=" to have NetworkManager
restore the permanent address.

https://bugzilla.gnome.org/show_bug.cgi?id=770611
 2016-09-12 14:01:57 +02:00
Thomas Haller 56bd86fd0c NEWS: update file with changes to PropertiesChanged signal 2016-09-02 20:13:36 +02:00
Thomas Haller 07e8ddbfd8 NEWS: update 
(cherry picked from commit 0a04b55491)
 2016-08-23 22:52:28 +02:00
Thomas Haller 965df5c571 NEWS: fix spelling 
(cherry picked from commit 154c86efc6)
 2016-08-23 22:44:24 +02:00
Lubomir Rintel cb6f1f5751 release: update NEWS with recently merged features 2016-08-17 16:20:42 +02:00
Beniamino Galvani 65e522ee16 release: update NEWS 2016-08-03 09:39:03 +02:00
Thomas Haller e0e1c59160 NEWS: fix mistake in NEWS file about wifi.mac-address-randomization 2016-05-19 12:11:38 +02:00
Lubomir Rintel dbdb455cc8 release: update NEWS 2016-03-29 16:10:25 +02:00
Thomas Haller c1383371cc NEWS: minor update referencing 1.0.10 release 2016-03-16 12:29:46 +01:00
Beniamino Galvani 24e3306b87 release: update NEWS 2016-03-01 09:56:14 +01:00
Beniamino Galvani 2446da1564 release: improve NEWS 2016-01-21 11:42:42 +01:00
Lubomir Rintel ecd729706e relese: fix NEWS formatting 
The double spacing was probably a mistake. Also, there was an extra line break.
 2016-01-19 15:10:35 +01:00
Lubomir Rintel 636380d19d release: update NEWS 2016-01-18 13:06:30 +01:00
Thomas Haller d4b257b613 NEWS: mention missing feature for 1.0 2015-01-27 21:46:01 +01:00
Dan Williams ee65399030 release: update NEWS 2014-12-18 12:07:13 -06:00
Dan Williams 4b7a736c40 build: update NEWS 2014-11-20 15:15:10 -06:00
Jiří Klimeš a7eae7a553 trivial: typo in the NEWS 2014-06-09 09:15:40 +02:00
Dan Williams 3470b3aafd release: update NEWS 2014-06-06 18:28:21 -05:00
Dan Williams 16c99c035d release: update NEWS 2013-01-15 16:57:20 -06:00
Dan Williams deee062754 release: update NEWS 2012-08-07 11:04:14 -05:00
Dan Williams 3684435e58 release: update NEWS 2012-07-23 18:13:08 -05:00
Dan Williams d40399d285 release: update NEWS 2012-06-27 10:33:13 -05:00
Dan Williams dcceaf40c0 release: update NEWS 2012-06-12 11:50:20 -05:00
Dan Williams 7054f7ad88 release: update NEWS with ADSL support 2012-05-18 16:26:10 -05:00
Dan Williams 27fdc1a42c release: update NEWS 2012-05-01 12:59:11 -05:00
Dan Williams f5f85f8a83 release: update NEWS 2012-03-23 15:11:02 -05:00
Dan Williams deb042c656 release: update NEWS 2012-03-16 10:48:02 -05:00
Dan Williams b480e5a4f2 release: update NEWS 2012-03-15 15:19:22 -05:00
Dan Williams e0613ac67c release: update NEWS 2012-03-01 18:02:13 -06:00
Dan Williams cf6482baea release: update NEWS 2012-02-16 15:39:03 -06:00
Dan Williams a5de613d67 release: update NEWS 2011-12-02 13:56:03 -06:00
Dan Williams 9c0bfd0d03 release: update NEWS 2011-11-09 23:50:29 -06:00
Dan Williams c25b97b39f release: update NEWS 2011-11-07 13:33:03 -06:00
Dan Williams cddf97486b release: update NEWS 2011-10-28 12:17:03 -05:00