From daadb8fbe96558e8de768518aaf130cb0cff0abe Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Thu, 8 Feb 2018 14:30:49 +0000 Subject: [PATCH] libnm-util: Fix a minor type problem with GValue MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The code was passing the gpointer alias of the GValue, rather than the GValue* itself. This doesn’t matter normally, but broke an experimental patch in GLib to remove a cast from G_VALUE_TYPE. We’ve reverted the patch in GLib (see https://bugzilla.gnome.org/show_bug.cgi?id=793186), but this should be fixed in NetworkManager anyway. Signed-off-by: Philip Withnall https://bugzilla.gnome.org/show_bug.cgi?id=793302 --- libnm-util/nm-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libnm-util/nm-utils.c b/libnm-util/nm-utils.c index 7f927d2451..5d80b2a4f8 100644 --- a/libnm-util/nm-utils.c +++ b/libnm-util/nm-utils.c @@ -470,7 +470,7 @@ value_dup (gpointer key, gpointer val, gpointer user_data) GValue *dup_value; dup_value = g_slice_new0 (GValue); - g_value_init (dup_value, G_VALUE_TYPE (val)); + g_value_init (dup_value, G_VALUE_TYPE (value)); g_value_copy (value, dup_value); g_hash_table_insert (table, g_strdup ((char *) key), dup_value);