system/NetworkManager
system/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager synced 2024-07-22 02:35:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

device/trivial: add FIXME comment about simplifying deactivate_async()

Browse source
This commit is contained in:
Thomas Haller 2020-02-14 10:10:26 +01:00
parent ecddb4c29b
commit d165787b54
1 changed files with 25 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/devices/nm-device.c
View file

@ -15545,6 +15545,31 @@ deactivate_dispatcher_complete (NMDispatcherCallId *call_id, gpointer user_data)
nm_assert_not_reached ();
if (NM_DEVICE_GET_CLASS (self)->deactivate_async) {
/* FIXME: the virtual function deactivate_async() has only this caller here.
* And the NMDevice subtypes are well aware of the circumstances when they
* are called. We shall make the function less generic and thus (as the scope
* is narrower) more convenient.
*
* - Drop the callback argument. Instead, when deactivate_async() completes, the
* subtype shall call a method _nm_device_deactivate_async_done(). Because as
* it is currently, subtypes need to pretend this callback and the user-data
* would be opaque, and carry it around. When it's in fact very clear what this
* is.
*
* - Also drop the GCancellable argument. Upon cancellation, NMDevice shall
* call another virtual function deactivate_async_abort(). As it is currently,
* callers need to register to the cancelled signal of the cancellable. It
* seems simpler to just implement the deactivate_async_abort() function.
* On the other hand, some implementations actually use the GCancellable.
* So, NMDevice shall do both: it shall both pass a cancellable, but also
* invoke deactivate_async_abort(). It allow the implementation to honor
* whatever is simpler for their purpose.
*
* - sometimes, the subclass can complete right away. Scheduling the completion
* in an idle handler is cumbersome. Allow the function to return FALSE to
* indicate that the device is already deactivated and the callback (or
* _nm_device_deactivate_async_done()) won't be invoked.
*/
priv->deactivating_cancellable = g_cancellable_new ();
NM_DEVICE_GET_CLASS (self)->deactivate_async (self,
priv->deactivating_cancellable,