system/NetworkManager
system/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager synced 2024-10-04 15:21:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

examples: avoid unreachable code in "gmaincontext.py"

Browse source 
lgtm.com warns about this. Avoid it.
This commit is contained in:
Thomas Haller 2022-10-25 12:36:37 +02:00
parent ea5cd47bc4
commit c34c8fdb82
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
examples/python/gi/gmaincontext.py
View file

@ -259,7 +259,6 @@ def create_nmc(dbus_connection):
# This actually should not happen. There is no other reason why
# initialization can fail.
assert False, "NMClient initialization is not supposed to fail"
return nmc
###############################################################################
@ -296,12 +295,11 @@ def make_call(nmc):
else:
log(f"[make_call]: dbus_call() completed with error: {e}")
if False:
# I don't understand why, but if you hit this exception (e.g. by setting a low
# timeout) and pass the exception to the out context, then an additional reference
# to nmc is leaked, and destroy_nmc() will fail. Workaround
r.error = e
# I don't understand why, but if you hit this exception (e.g. by setting a low
# timeout) and pass the exception to the out context, then an additional reference
# to nmc is leaked, and destroy_nmc() will fail. Workaround
#
#r.error = e
r.error = str(e)
else:
log(