system/NetworkManager
system/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager synced 2024-10-07 00:31:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

libnm: avoid printing NULL string at NMSettingBondPort.verify()

Browse source 
printf() is not guaranteed to properly handle NULL string,
although glibc will print "(null)".

Avoid that by not printing the currently set value. The error
message is anyway already very long.
This commit is contained in:
Thomas Haller 2021-08-26 23:01:12 +02:00
parent 222c070412
commit bf13ec2df2
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/libnm-core-impl/nm-setting-bond-port.c
View file

@ -89,11 +89,9 @@ verify(NMSetting *setting, NMConnection *connection, GError **error)
g_set_error(error,
NM_CONNECTION_ERROR,
NM_CONNECTION_ERROR_INVALID_PROPERTY,
_("A connection with a '%s' setting must have the slave-type set to '%s'. "
"Instead it is '%s'"),
_("A connection with a '%s' setting must have the slave-type set to '%s'"),
NM_SETTING_BOND_PORT_SETTING_NAME,
NM_SETTING_BOND_SETTING_NAME,
slave_type);
NM_SETTING_BOND_SETTING_NAME);
g_prefix_error(error,
"%s.%s: ",
NM_SETTING_CONNECTION_SETTING_NAME,