system/NetworkManager
system/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager synced 2024-10-14 20:18:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

ovs: enable trace logging not only with NM_MORE_LOGGING

Browse source 
The logging is useful. Always compile it in.
This commit is contained in:
Thomas Haller 2020-05-08 14:16:53 +02:00
parent 2929392855
commit b533bef8cd
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/devices/ovs/nm-ovsdb.c
View file

@ -131,10 +131,9 @@ typedef struct {
#define OVSDB_MAX_FAILURES 3
static void
_call_trace (const char *comment, OvsdbMethodCall *call, json_t *msg)
_LOGT_call_do (const char *comment, OvsdbMethodCall *call, json_t *msg)
{
#if NM_MORE_LOGGING
char *str = NULL;
gs_free char *str = NULL;
if (msg)
str = json_dumps (msg, 0);
@ -169,12 +168,14 @@ _call_trace (const char *comment, OvsdbMethodCall *call, json_t *msg)
call->mtu);
break;
}
if (msg)
g_free (str);
#endif
}
#define _LOGT_call(comment, call, message) \
G_STMT_START { \
if (_LOGT_ENABLED ()) \
_LOGT_call_do ((comment), (call), (message)); \
} G_STMT_END
/**
* ovsdb_call_method:
*
@ -226,7 +227,7 @@ ovsdb_call_method (NMOvsdb *self, OvsdbCommand command,
break;
}
_call_trace ("enqueue", call, NULL);
_LOGT_call ("enqueue", call, NULL);
ovsdb_next_command (self);
}
@ -875,7 +876,7 @@ ovsdb_next_command (NMOvsdb *self)
}
g_return_if_fail (msg);
_call_trace ("send", call, msg);
_LOGT_call ("send", call, msg);
cmd = json_dumps (msg, 0);
g_string_append (priv->output, cmd);
@ -1247,7 +1248,7 @@ ovsdb_got_msg (NMOvsdb *self, json_t *msg)
}
/* Cool, we found a corresponding call. Finish it. */
_call_trace ("response", call, msg);
_LOGT_call ("response", call, msg);
if (!json_is_null (error)) {
/* The response contains an error. */