From 1c0aa397b372cf6cccaacd11546cc99011090d35 Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Fri, 15 Jun 2018 15:17:28 +0200 Subject: [PATCH 1/7] libnm: correctly demarshall (u)int64 values --- libnm/nm-object.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libnm/nm-object.c b/libnm/nm-object.c index f162b15dc0..da2fbb79c0 100644 --- a/libnm/nm-object.c +++ b/libnm/nm-object.c @@ -900,9 +900,9 @@ demarshal_generic (NMObject *object, else if (pspec->value_type == G_TYPE_UINT) HANDLE_TYPE (G_VARIANT_TYPE_UINT32, guint, g_variant_get_uint32); else if (pspec->value_type == G_TYPE_INT64) - HANDLE_TYPE (G_VARIANT_TYPE_INT64, gint, g_variant_get_int64); + HANDLE_TYPE (G_VARIANT_TYPE_INT64, gint64, g_variant_get_int64); else if (pspec->value_type == G_TYPE_UINT64) - HANDLE_TYPE (G_VARIANT_TYPE_UINT64, guint, g_variant_get_uint64); + HANDLE_TYPE (G_VARIANT_TYPE_UINT64, guint64, g_variant_get_uint64); else if (pspec->value_type == G_TYPE_LONG) HANDLE_TYPE (G_VARIANT_TYPE_INT64, glong, g_variant_get_int64); else if (pspec->value_type == G_TYPE_ULONG) From 07fd0502f68a1116ee4cfdb31b24b422b142847f Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Fri, 15 Jun 2018 13:57:30 +0200 Subject: [PATCH 2/7] wifi: expose LastScan as milliseconds not seconds This doesn't wrap around in 68 years of uptime and is consistent with o.fd.NM.Checkpoint.Created. --- clients/cli/devices.c | 2 +- ...desktop.NetworkManager.Device.Wireless.xml | 4 +-- libnm/nm-device-wifi.c | 20 ++++++------- libnm/nm-device-wifi.h | 4 +-- shared/nm-utils/nm-shared-utils.h | 5 ++-- src/devices/wifi/nm-device-iwd.c | 18 +++++------ src/devices/wifi/nm-device-wifi.c | 30 +++++++++---------- src/devices/wifi/nm-wifi-common.c | 2 +- src/supplicant/nm-supplicant-interface.c | 16 +++++----- src/supplicant/nm-supplicant-interface.h | 2 +- tools/test-networkmanager-service.py | 2 +- 11 files changed, 53 insertions(+), 52 deletions(-) diff --git a/clients/cli/devices.c b/clients/cli/devices.c index d92978f5a6..235690980f 100644 --- a/clients/cli/devices.c +++ b/clients/cli/devices.c @@ -2770,7 +2770,7 @@ wifi_list_aps (NMDeviceWifi *wifi, gboolean needs_rescan; WifiListData *data; - needs_rescan = rescan_cutoff < 0 || (rescan_cutoff > 0 && nm_device_wifi_get_last_scan (wifi) < rescan_cutoff); + needs_rescan = rescan_cutoff < 0 || (rescan_cutoff > 0 && nm_device_wifi_get_last_scan (wifi) < (rescan_cutoff * 1000)); if (needs_rescan) { data = g_slice_new0 (WifiListData); diff --git a/introspection/org.freedesktop.NetworkManager.Device.Wireless.xml b/introspection/org.freedesktop.NetworkManager.Device.Wireless.xml index af6e8c7ff3..130385455c 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Wireless.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Wireless.xml @@ -99,12 +99,12 @@ - +